-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated dependency manager #58
Conversation
script: | ||
- go build -v -tags 'cert sqlite pam miniwinsvc' | ||
- | | ||
for pkg in $(go list ./... | grep -v /vendor/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't this be written as instead?
go test -v race -cover -coverprofile coverage.out $(go list ./... | grep -v /vendor/)
Or do we need to split them up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, cannot use test profile flag with multiple packages
You forgot to vendor test packages. See the Travis output:
|
Working on it. |
Ready for review/merge |
LGTM |
Rebased |
LGTM |
* Fix parsing bug in GetTagInfos * Comment
I have integrated all dependencies with govendor and also updated the travis configuration since we don't need to download the dependencies anymore. This also fixes #29.