Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5525 Fix the Let's Encrypt handler #5527

Merged
merged 1 commit into from
Dec 11, 2018

Commits on Dec 11, 2018

  1. Backported go-gitea#5525 Fix the Let's Encrypt handler

    * Fix the Let's Encrypt handler by listening on a valid address
    
    Also handle errors in the HTTP server go routine, return a fatal error
    when something goes wrong.
    
    Thanks to @gbl08ma for finding the actual bug
    
    Here is an example of the error handling:
    
        2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
        start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
        permission denied
    
    Closes go-gitea#5280
    
    * Fix a typo
    gregkare committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    6bd18b6 View commit details
    Browse the repository at this point in the history