Skip to content

Remove unused db init on commands serv, update, hooks #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 3 commits into from
Oct 30, 2018
Merged

Remove unused db init on commands serv, update, hooks #5225

lafriks merged 3 commits into from
Oct 30, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 30, 2018

Blocked by #4886

@lunny lunny added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Oct 30, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 30, 2018
@codecov-io
Copy link

codecov-io commented Oct 30, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5fc0a12). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5225   +/-   ##
=========================================
  Coverage          ?   37.51%           
=========================================
  Files             ?      310           
  Lines             ?    45929           
  Branches          ?        0           
=========================================
  Hits              ?    17229           
  Misses            ?    26231           
  Partials          ?     2469

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc0a12...8cb1d23. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2018
@lunny lunny removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 30, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2018
@lafriks lafriks merged commit 0ba5794 into go-gitea:master Oct 30, 2018
@lunny lunny deleted the lunny/remove_unused_db_init branch October 30, 2018 10:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @codecov-io @lafriks @sapk @bkcsoft