Skip to content

Fixed bug where team with admin privelege type doesn't get any unit #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 21, 2018
Merged

Fixed bug where team with admin privelege type doesn't get any unit #4719

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
765eec4
Fixed bug where team with admin privelege type doesn't get any unit a…
adelowo Aug 15, 2018
1fb7009
Merge branch 'master' of https://github.com/go-gitea/gitea into fix_t…
adelowo Aug 15, 2018
79ae98b
Merge branch 'master' into fix_team_admin_permissionn
adelowo Aug 16, 2018
ca82226
Merge branch 'master' into fix_team_admin_permissionn
adelowo Aug 18, 2018
3937dea
Merge branch 'master' into fix_team_admin_permissionn
adelowo Aug 21, 2018
bebd25d
Merge branch 'master' into fix_team_admin_permissionn
techknowlogick Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions routers/org/teams.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ func NewTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
Description: form.Description,
Authorize: models.ParseAccessMode(form.Permission),
}
if t.Authorize < models.AccessModeAdmin {

if t.Authorize < models.AccessModeOwner {
var units = make([]*models.TeamUnit, 0, len(form.Units))
for _, tp := range form.Units {
units = append(units, &models.TeamUnit{
Expand Down Expand Up @@ -275,7 +276,7 @@ func EditTeamPost(ctx *context.Context, form auth.CreateTeamForm) {
}
}
t.Description = form.Description
if t.Authorize < models.AccessModeAdmin {
if t.Authorize < models.AccessModeOwner {
var units = make([]models.TeamUnit, 0, len(form.Units))
for _, tp := range form.Units {
units = append(units, models.TeamUnit{
Expand Down