Fix SHA and compare regex on route file [Critical] #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@0xBAADF00D can you make your original PR here instead of in Gogs repository? |
Contributor
Member
Author
|
@0xBAADF00D yeah, go ahead a create new PR since you did the work. To answer your question about why to fork, I would suggest your to pay a visit on gitter (https://gitter.im/go-gitea/gitea) to discuss. |
delvh
added
issue/not-a-bug
pieer
added a commit
to ikigau/gitea
that referenced
this pull request
Oct 27, 2025
…idation logic The frontend generateRepoNameFromSubject() function was inconsistent with the backend validation rules defined in models/repo/repo.go. Backend validation rules (from IsUsableRepoName): - Pattern: ^[-.\\w]+$ (hyphen, dot, word chars: a-zA-Z0-9_) - Invalid: consecutive dots (2+) - Reserved names: ".", "..", "-" - Reserved patterns: *.wiki, *.git, *.rss, *.atom Changes made to align frontend with backend: 1. Added consecutive dot collapsing - Backend rejects names with 2+ consecutive dots - Frontend now collapses multiple dots to single dot - Example: "my...repo" → "my.repo" 2. Added reserved pattern handling - Backend rejects *.wiki, *.git, *.rss, *.atom - Frontend now appends "-repo" suffix to avoid these - Example: "my-project.git" → "my-project.git-repo" 3. Enhanced comments to reference backend validation - Documents which backend rules are being matched - Makes maintenance easier by linking frontend/backend 4. Kept existing beneficial frontend logic - Consecutive hyphen collapsing (improves readability) - Leading/trailing character removal (prevents reserved names) - These don't conflict with backend validation This ensures users get immediate feedback that matches backend validation, preventing confusing errors after form submission.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of Gogs PR #3848