Skip to content

Increase default TOTP secret size to 320 bits #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Increase default TOTP secret size to 320 bits #4287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b36ac6
Increase default TOTP secret size to 320 bits
Jun 21, 2018
7566b96
Merge branch 'master' into master
Jul 3, 2018
8ad6eb6
Merge branch 'master' into master
techknowlogick Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions routers/user/setting/security_twofa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func twofaGenerateSecretAndQr(ctx *context.Context) bool {
if otpKey == nil {
err = nil // clear the error, in case the URL was invalid
otpKey, err = totp.Generate(totp.GenerateOpts{
SecretSize: 40,
Issuer: setting.AppName + " (" + strings.TrimRight(setting.AppURL, "/") + ")",
AccountName: ctx.User.Name,
})
Expand Down