Skip to content

fix CreateIssueCommentOption reference #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
Jun 15, 2018
Merged

fix CreateIssueCommentOption reference #4239

lunny merged 2 commits into from
Jun 15, 2018

Conversation

@stevegt
Copy link
Contributor

@stevegt stevegt commented Jun 13, 2018

@codecov-io
Copy link

codecov-io commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #4239 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4239      +/-   ##
==========================================
+ Coverage   19.96%   19.97%   +<.01%     
==========================================
  Files         153      153              
  Lines       30521    30521              
==========================================
+ Hits         6094     6097       +3     
+ Misses      23513    23511       -2     
+ Partials      914      913       -1
Impacted Files Coverage Δ
routers/api/v1/repo/issue_comment.go 0% <0%> (ø) ⬆️
modules/avatar/avatar.go 100% <0%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75f251...d02d8db. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 14, 2018
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jun 15, 2018
@lunny lunny added this to the 1.5.0 milestone Jun 15, 2018
@lunny
Copy link
Member

lunny commented Jun 15, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2018
@lunny lunny merged commit a7aaacb into go-gitea:master Jun 15, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonasfranz jonasfranz jonasfranz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stevegt @codecov-io @lunny @jonasfranz @bkcsoft