Skip to content

Fix blank topic #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 2 commits into from
May 11, 2018
Merged

Fix blank topic #3948

lunny merged 2 commits into from
May 11, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented May 11, 2018

Will fix #3927

@lunny lunny added the type/bug label May 11, 2018
@lunny lunny added this to the 1.5.0 milestone May 11, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 11, 2018
@codecov-io
Copy link

codecov-io commented May 11, 2018 •
edited
Loading

Codecov Report

Merging #3948 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
- Coverage   20.27%   20.27%   -0.01%     
==========================================
  Files         146      146              
  Lines       29316    29319       +3     
==========================================
  Hits         5945     5945              
- Misses      22470    22473       +3     
  Partials      901      901
Impacted Files Coverage Δ
routers/repo/topic.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc84007...e0eebcf. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2018
@lunny
Copy link
Member Author

lunny commented May 11, 2018

make L-G-T-M work

@lunny lunny merged commit c14870c into go-gitea:master May 11, 2018
@lunny lunny deleted the lunny/fix_blank_topic branch May 11, 2018 08:15
@techknowlogick techknowlogick mentioned this pull request May 12, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@appleboy appleboy appleboy approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Empty repository topic tag after clearing topics

5 participants

@lunny @codecov-io @appleboy @jonasfranz @bkcsoft