Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more webhooks support and refactor webhook templates directory #3929

Merged
merged 12 commits into from
May 16, 2018
Merged

Add more webhooks support and refactor webhook templates directory #3929

merged 12 commits into from
May 16, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented May 9, 2018

This PR will add delete, fork, issues, issue_comment, release webhooks to Gitea. It dependents go-gitea/go-sdk#106 and need UI work.

@lunny lunny added the type/enhancement An improvement of existing functionality label May 9, 2018
@lunny lunny added this to the 1.x.x milestone May 9, 2018
@lunny lunny changed the title [WIP] Add more webhook support [WIP] Add more webhooks support May 11, 2018
@lunny lunny changed the title [WIP] Add more webhooks support Add more webhooks support and refactor webhook templates directory May 11, 2018
@lafriks
Copy link
Member

lafriks commented May 13, 2018

@lunny tests fail

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2018
@lunny
Copy link
Member Author

lunny commented May 13, 2018

@lafriks, it's still the vendor failed. Maybe I forgot to merge your PR. I think you should have permissions to push this PR directly since I have checked Allow edits from maintainers.

@codecov-io
Copy link

codecov-io commented May 16, 2018 •
edited
Loading

Codecov Report

Merging #3929 into master will decrease coverage by 0.19%.
The diff coverage is 11.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3929     +/-   ##
=========================================
- Coverage   20.28%   20.08%   -0.2%     
=========================================
  Files         146      146             
  Lines       29302    29867    +565     
=========================================
+ Hits         5944     6000     +56     
- Misses      22457    22961    +504     
- Partials      901      906      +5
Impacted Files Coverage Δ
routers/api/v1/repo/issue_comment.go 0% <0%> (ø) ⬆️
models/webhook_dingtalk.go 0% <0%> (ø) ⬆️
models/issue_comment.go 27.53% <0%> (-3.66%) ⬇️
models/repo.go 17.89% <0%> (-0.11%) ⬇️
models/release.go 0% <0%> (ø) ⬆️
models/webhook_discord.go 1.66% <0%> (-1.48%) ⬇️
routers/repo/issue.go 0.92% <0%> (-0.01%) ⬇️
routers/repo/webhook.go 0% <0%> (ø) ⬆️
models/webhook_slack.go 0% <0%> (ø) ⬆️
models/webhook.go 50.64% <100%> (+4.53%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188fe6c...a1e794f. Read the comment docs.

@lunny lunny modified the milestones: 1.x.x, 1.5.0 May 16, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2018
@bkcsoft bkcsoft removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 16, 2018
@bkcsoft bkcsoft added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label May 16, 2018
@lunny lunny merged commit 24941a1 into go-gitea:master May 16, 2018
@lunny lunny deleted the lunny/more_hook_event branch May 16, 2018 14:02
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label May 16, 2018
This was referenced May 17, 2018
Closed
Closed
Closed
Closed
Closed
lunny added a commit to lunny/gitea that referenced this pull request May 21, 2018
@lunny
fix bugs caused by go-gitea#3929
ec25b95
lunny added a commit that referenced this pull request May 23, 2018
@lunny
fix bugs caused by #3929 (#3999)
60d95a0
aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
@aswild
Merge tag 'v1.5.0-rc1' into wild/v1.5
9b336e6 
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @lafriks @codecov-io @appleboy @bkcsoft @delvh