refactor: routing info middleware#37653
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes #37650 by ensuring routing request metadata (used by helpers like routing.MarkLongPolling) is always present in the request context, even when the router logger is disabled, preventing nil-pointer panics in dev mode (e.g. Vite dev proxy).
Changes:
- Replace conditional
routing.NewLoggerHandler()registration with an always-onrouting.NewRequestInfoHandler()middleware. - Refactor routing logger internals to decouple “request info in context” from “router logging + slow query detection”.
- Rename/reshape
requestRecordfields to align with the refactor (responseWriter→respWriter, mutable fields grouped).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| routers/common/middleware.go | Always installs request-info middleware so request records exist even when router logging is disabled. |
| modules/web/routing/requestrecord.go | Restructures requestRecord fields and renames writer field. |
| modules/web/routing/requestinfo.go | New middleware that always injects request record; optionally enables router logging/slow query detection. |
| modules/web/routing/logger.go | Updates logger to use renamed respWriter field. |
| modules/web/routing/logger_manager.go | Refactors request-record manager logic to work with the new request-info middleware. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wxiaoguang
force-pushed
the
fix-request-info
branch
from
f29170c to
52fbb82
Compare
wxiaoguang
force-pushed
the
fix-request-info
branch
from
52fbb82 to
4d4ee68
Compare
wxiaoguang
added
the
skip-changelog
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 11, 2026
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 12, 2026
* main: fix(deps): update dependency mermaid to v11.15.0 [security], add e2e test (go-gitea#37662) ci: Also lint json5 files (go-gitea#37659) fix(templates): avoid misleading compare message when branches lack merge base (go-gitea#37651) fix(deps): update npm dependencies (go-gitea#37647) refactor: routing info middleware (go-gitea#37653) chore(deps): update action dependencies (major) (go-gitea#37638) fix(deps): update go dependencies (major) (go-gitea#37639) ci(renovate): update Go import paths on major bumps (go-gitea#37641) fix(packages): Add label for private and internal package and fix composor package source permission check (go-gitea#37610) refactor: replace Fomantic search module with first-party code (go-gitea#37443) fix(deps): update npm dependencies (go-gitea#37636) fix(deps): update module code.gitea.io/sdk/gitea to v0.25.0 (go-gitea#37637) feat(api): add last_sync to repository API (go-gitea#37566) test(e2e): run playwright via container (go-gitea#37300) feat(editor): broaden language detection in web code editor (go-gitea#37619) refactor(log): replace log.Critical with log.Error (go-gitea#37624) fix: "run as root" check (go-gitea#37622) fix: improve actions status icons and texts (go-gitea#37206) # Conflicts: # pnpm-workspace.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #37650