Stabilize e2e logout propagation test#37408
Merged
silverwind merged 1 commit intogo-gitea:release/v1.26from Apr 24, 2026
Merged
Stabilize e2e logout propagation test#37408silverwind merged 1 commit intogo-gitea:release/v1.26from
silverwind merged 1 commit intogo-gitea:release/v1.26from
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/testing
skip-changelog
silverwind
changed the title
silverwind
changed the title
Member
Author
|
#37403 was merged, this is ready. |
Backport of go-gitea#37403 to release/v1.26. Give page2's SharedWorker time to register its SSE connection on the server before page1 triggers logout — otherwise the event can be silently dropped when no messenger is registered yet for the user. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind
force-pushed
the
fix-e2e-logout-flake-v1.26-2
branch
from
ac12d1e to
f00c016
Compare
silverwind
force-pushed
the
fix-e2e-logout-flake-v1.26-2
branch
from
0a53bc8 to
f00c016
Compare
bircni
approved these changes
Apr 24, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 24, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37403 to
release/v1.26.The
events › logout propagatione2e test was racing the SSE connection setup: if page2's SharedWorker had not finished registering its messenger by the time page1 triggered logout, the event was silently dropped and page2 stayed on the authenticated page.Wait 500ms after verifying page2 is signed in, before triggering the logout from page1, so the SharedWorker has time to register. Comment points at a cleaner future fix (expose a ready attribute on the page) that will also work for the planned WebSocket SharedWorker.
This PR was written with the help of Claude Opus 4.7