Fix inconsistent disabled styling on logged-out repo header buttons by silverwind · Pull Request #37406 · go-gitea/gitea

silverwind · 2026-04-24T10:44:36Z

Make the watch, star, and fork buttons in the repo header consistent for logged-out users:

Apply the same faded/disabled look to all three buttons (number labels included), instead of only the action button being grayed.
Clicking any of them while logged out now leads to the login page (with a redirect back) instead of being inert.
Split the per-button markup out of header.tmpl into a dedicated templates/repo/header/ folder (fork.tmpl, star.tmpl, watch.tmpl).

This PR was written with the help of Claude Opus 4.7

wxiaoguang

Then, you also disabled the "tooltip"

silverwind · 2026-04-24T11:16:22Z

Maybe it needs a data-tooltip-show-when-disabled.

wxiaoguang · 2026-04-24T11:17:08Z

No, you can't do so.

You also disabled the links.

Anonymous visitor can click the links to visit the "watchers" page.

wxiaoguang · 2026-04-24T11:22:37Z

Maybe it needs a data-tooltip-show-when-disabled.

It is definitely your guess which would make the system more messy. Everything should go as what it should, don't use unnecessary tricks to make things more complicated than it should.

TBH, I've lost count of how many bugs I have caught and blocked during the PR review stage. Otherwise, I can't imagine how many regression reports there would be when a new release is published.

silverwind · 2026-04-24T11:22:53Z

Hmm, maybe CSS-only border fix then.

silverwind · 2026-04-24T11:39:52Z

Fix is now CSS only, a bit complicated selectors but see no other way.

wxiaoguang · 2026-04-24T11:41:58Z

Fix is now CSS only, a bit complicated selectors but see no other way.

The simplest way is to make the "watch" button have pointer-events: none;, it doesn't need to be really "disabled" since it already has a proper tooltip

Move the `disabled` class from the inner `<button>` to the wrapping `.ui.labeled.button` div on watch and star so all three buttons render consistently, matching the existing fork button pattern. Re-enable pointer events on the wrapper itself (so the tooltip still fires) and apply `pointer-events: none` only to the inner button, leaving the label link clickable. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-24T12:10:23Z

Fix is now CSS only, a bit complicated selectors but see no other way.

The simplest way is to make the "watch" button have pointer-events: none;, it doesn't need to be really "disabled" since it already has a proper tooltip

Done in 53810c1.

wxiaoguang · 2026-04-24T14:33:08Z

Complete fix should be like this 89469fe

The if check for data-fetch-url is removed because since the button is not clickable, the attributes do nothing, no need to make to that complex.

dismiss

silverwind · 2026-04-24T15:35:46Z

Complete fix should be like this 89469fe

The if check for data-fetch-url is removed because since the button is not clickable, the attributes do nothing, no need to make to that complex.

Hmm it's not quite consistent, checking.

Add tw-opacity-[var(--opacity-disabled)] to the wrapper so the three buttons visually fade when unavailable, matching the previous look. Apply the same pointer-events-none + opacity pattern to the fork button for full three-way consistency. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-24T16:00:23Z

These templates are a bit messy, I will extract into new sub-templates for repo header content.

Relocate watch_unwatch.tmpl and star_unstar.tmpl into templates/repo/header/ and extract the inline fork button (+ modal) out of header.tmpl into header/fork.tmpl. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-24T16:11:04Z

All 3 buttons now live in a new templates/repo/header folder, that way we won't forget to make them consistent in the future. Manually tested the rendering, all looks fine.

wxiaoguang · 2026-04-24T16:12:16Z

But no, the "link" is clickable, it shouldn't be disabled, shouldn't use "disabled" color.

I believe my solution is already the correct one, and simple enough

silverwind · 2026-04-24T16:15:18Z

But no, the "link" is clickable, it shouldn't be disabled, shouldn't use "disabled" color.

I believe my solution is already the correct one, and simple enough

But we want to indicate reduced functionality over the whole button+counter imho, that's what the opacity now does.

Or maybe we just scrap the whole idea and remove the opacity trick altogether making them render the same logged in and logged out? Might be cleaner.

wxiaoguang · 2026-04-24T16:19:02Z

But no, the "link" is clickable, it shouldn't be disabled, shouldn't use "disabled" color.
I believe my solution is already the correct one, and simple enough

But we want to indicate reduced functionality over the whole button+counter imho, that's what the opacity now does.

The counter link just works, why it should be reduced for its functionality.

Or maybe we just scrap the whole idea and remove the opacity trick altogether making them render the same logged in and logged out? Might be cleaner.

It is my commit 89469fe

And I have explained the details in comments.

wxiaoguang · 2026-04-24T16:20:13Z

Or maybe we just scrap the whole idea and remove the opacity trick altogether making them render the same logged in and logged out? Might be cleaner.

It is my commit 89469fe

And I have explained the details in comments.

Or even better, lead users to login, then no need to disable anything.

silverwind · 2026-04-24T16:24:35Z

Or even better, lead users to login, then no need to disable anything.

I'll do that. IIRC, that is also how GitHub handles it.

Remove all disabled-state visual styling (opacity, cursor-default, pointer-events helpers, "not using disabled" comments) on the watch, star and fork buttons. For logged-out users the action element becomes a plain link to /user/login?redirect_to=<current-page>, so the buttons render identically whether signed in or not. Fork's signed-but-cannot-fork-own-repo path keeps tw-pointer-events-none on the inner link to block clicks while still showing its tooltip. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

silverwind · 2026-04-24T17:00:04Z

Done in 23bcbbd, manually tested all behaviours.

Copilot

Pull request overview

This PR aims to make the repo header watch/star/fork controls behave consistently in the logged-out (and other non-actionable) states by refactoring them into dedicated header templates and adjusting how the controls are rendered.

Changes:

Extract watch/star/fork header controls into templates/repo/header/* templates and update templates/repo/header.tmpl to use them.
Update watch/star action routers to render the new partial template names for fetch-sync updates.
Adjust watch/star/fork “guest” rendering to use login links (and reorganize fork modal rendering).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
templates/repo/header/watch.tmpl	Reworks watch control markup (button → anchor) and guest behavior.
templates/repo/header/star.tmpl	Reworks star control markup (button → anchor) and guest behavior.
templates/repo/header/fork.tmpl	Introduces extracted fork control template and fork selection modal.
templates/repo/header.tmpl	Switches repo header to use the new extracted watch/star/fork templates.
routers/web/repo/watch.go	Updates the watch action partial template name to the new header template.
routers/web/repo/star.go	Updates the star action partial template name to the new header template.

Comments suppressed due to low confidence (2)

templates/repo/header/watch.tmpl:8

When the user is signed in, this is rendered as an without an href. Anchors without href are not keyboard-focusable, which is an accessibility regression compared to the previous . Consider adding href="#" (the fetch-action handler already calls preventDefault) or use a for the signed-in case and keep the guest case as a link to login.
templates/repo/header/star.tmpl:8
Same issue as watch: in the signed-in branch this has no href, so it won’t be reachable via keyboard navigation. Add href="#" (click is prevented by the fetch-action handler) or keep using a for the fetch-action trigger.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* main: Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465) Fix compare dropdown for branches without common history (go-gitea#37470) FIX: URL sanitization to handle schemeless credentials (go-gitea#37440) Refactor pull request view (4) (go-gitea#37451) Fix scheduled action panic with null event payload (go-gitea#37459) Fix attachment Content-Security-Policy (go-gitea#37455) [skip ci] Updated translations via Crowdin Rename CurrentRefPath to CurrentRefSubURL (go-gitea#37453) Clean up org pages layout (go-gitea#37445) Fix script error alert (go-gitea#37458) Fix inconsistent disabled styling on logged-out repo header buttons (go-gitea#37406) Add API endpoint to reply to pull request review comments (go-gitea#36683) Add CurrentURL template variable back (go-gitea#37444)

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2026

silverwind added backport/v1.26 This PR should be backported to Gitea 1.26 type/enhancement An improvement of existing functionality labels Apr 24, 2026

wxiaoguang previously requested changes Apr 24, 2026

View reviewed changes

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2026

wxiaoguang marked this pull request as draft April 24, 2026 11:17

silverwind force-pushed the repo-header-disabled-consistency branch from 1055d48 to e577c2f Compare April 24, 2026 11:39

silverwind marked this pull request as ready for review April 24, 2026 11:39

silverwind force-pushed the repo-header-disabled-consistency branch from e577c2f to 53810c1 Compare April 24, 2026 11:48

fix

89469fe

fix comment

7dd0453

GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Apr 24, 2026

Move repo header button templates into a dedicated folder

e7cba5c

Relocate watch_unwatch.tmpl and star_unstar.tmpl into templates/repo/header/ and extract the inline fork button (+ modal) out of header.tmpl into header/fork.tmpl. Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>

wxiaoguang added 2 commits April 25, 2026 01:36

fix

5a8d771

fix layout

9679e20

wxiaoguang removed the backport/v1.26 This PR should be backported to Gitea 1.26 label Apr 24, 2026

silverwind requested a review from Copilot April 27, 2026 00:10

Copilot started reviewing on behalf of silverwind April 27, 2026 00:11 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

Comment thread templates/repo/header/fork.tmpl

Comment thread templates/repo/header.tmpl

Merge branch 'main' into repo-header-disabled-consistency

c0899b3

wxiaoguang approved these changes Apr 27, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2026

lunny added this to the 1.27.0 milestone Apr 27, 2026

lunny approved these changes Apr 27, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2026

Merge branch 'main' into repo-header-disabled-consistency

c3f6acf

wxiaoguang enabled auto-merge (squash) April 27, 2026 17:08

wxiaoguang merged commit 6da8027 into go-gitea:main Apr 27, 2026
26 checks passed

wxiaoguang deleted the repo-header-disabled-consistency branch April 27, 2026 17:33

Uh oh!

Conversation

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang left a comment

Choose a reason for hiding this comment

Uh oh!

silverwind commented Apr 24, 2026

Uh oh!

wxiaoguang commented Apr 24, 2026

Uh oh!

wxiaoguang commented Apr 24, 2026

Uh oh!

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 24, 2026

Uh oh!

wxiaoguang commented Apr 24, 2026

Uh oh!

silverwind commented Apr 24, 2026

Uh oh!

wxiaoguang commented Apr 24, 2026

Uh oh!

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 24, 2026

Uh oh!

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

silverwind commented Apr 24, 2026 •

edited

Loading

silverwind commented Apr 24, 2026 •

edited

Loading

silverwind commented Apr 24, 2026 •

edited

Loading

silverwind commented Apr 24, 2026 •

edited

Loading

wxiaoguang commented Apr 24, 2026 •

edited

Loading

silverwind commented Apr 24, 2026 •

edited

Loading

wxiaoguang commented Apr 24, 2026 •

edited

Loading

wxiaoguang commented Apr 24, 2026 •

edited

Loading

silverwind commented Apr 24, 2026 •

edited

Loading