Closed
Conversation
Backport of 8e85454 Fixes the issue that status report always shows "waiting to run" when already running, by comparing state, targetURL, and description (not just state) in the deduplication check. Co-authored-by: Nicolas <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (claude-sonnet-4-5) <noreply@anthropic.com> Agent-Logs-Url: https://github.com/go-gitea/gitea/sessions/1b315e9f-698c-4564-9ffa-aac1b9cb1692 Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>
GiteaBot
added
the
lgtm/need 2
Copilot created this pull request from a session on behalf of
silverwind
April 23, 2026 07:46
View session
silverwind
approved these changes
Apr 23, 2026
GiteaBot
added
lgtm/need 1
silverwind
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 8e85454 onto
release/v1.26.Summary
Fixes the issue where the commit status always shows "Waiting to run" even when the job has already started running.
The root cause:
WaitingandRunningboth map toCommitStatusPending, so the previous deduplication check (v.State == state) would find an existing "Waiting to run" status with statependingand skip creating a new "Has started running" entry.Fix: Change the deduplication check to compare
State,TargetURL, andDescription— so transitions between sub-states that share the same commit status state (e.g. Waiting → Running, bothpending) still produce a new commit status entry.Changes
services/actions/commit_status.go: ComputetargetURLanddescriptionbefore the dedup check; widen dedup condition to include all three fields; extracttoCommitStatusDescriptionhelper; remove unusedstrconvimport.services/actions/commit_status_test.go: New testTestCreateCommitStatus_Dedupeverifying correct dedup behaviour across Waiting → Running → Running (no-op) → Success transitions.