Add pr-review e2e test and speed up e2e tests

tests/e2e/codeeditor.test.ts

@@ -1,20 +1,16 @@
 import {env} from 'node:process';
 import {expect, test} from '@playwright/test';
-import {login, apiCreateRepo, apiDeleteRepo, randomString} from './utils.ts';
+import {login, apiCreateRepo, randomString} from './utils.ts';
 
 test('codeeditor textarea updates correctly', async ({page, request}) => {
   const repoName = `e2e-codeeditor-${randomString(8)}`;
   await Promise.all([apiCreateRepo(request, {name: repoName}), login(page)]);
-  try {
-    await page.goto(`/${env.GITEA_TEST_E2E_USER}/${repoName}/_new/main`);
-    await page.getByPlaceholder('Name your file…').fill('test.js');
-    await expect(page.locator('[data-tab="write"] .editor-loading')).toBeHidden();
-    const editor = page.locator('.cm-content[role="textbox"]');
-    await expect(editor).toBeVisible();
-    await editor.click();
-    await page.keyboard.type('const hello = "world";');
-    await expect(page.locator('textarea[name="content"]')).toHaveValue('const hello = "world";');
-  } finally {
-    await apiDeleteRepo(request, env.GITEA_TEST_E2E_USER, repoName);
-  }
+  await page.goto(`/${env.GITEA_TEST_E2E_USER}/${repoName}/_new/main`);
+  await page.getByPlaceholder('Name your file…').fill('test.js');
+  await expect(page.locator('[data-tab="write"] .editor-loading')).toBeHidden();
+  const editor = page.locator('.cm-content[role="textbox"]');
+  await expect(editor).toBeVisible();
+  await editor.click();
+  await page.keyboard.type('const hello = "world";');
+  await expect(page.locator('textarea[name="content"]')).toHaveValue('const hello = "world";');
 });

tests/e2e/events.test.ts

@@ -1,5 +1,5 @@
 import {test, expect} from '@playwright/test';
-import {loginUser, baseUrl, apiUserHeaders, apiCreateUser, apiDeleteUser, apiCreateRepo, apiCreateIssue, apiStartStopwatch, timeoutFactor, randomString} from './utils.ts';
+import {loginUser, baseUrl, apiUserHeaders, apiCreateUser, apiCreateRepo, apiCreateIssue, apiStartStopwatch, timeoutFactor, randomString} from './utils.ts';
 
 // These tests rely on a short EVENT_SOURCE_UPDATE_TIME in the e2e server config.
 test.describe('events', () => {
@@ -15,6 +15,7 @@ test.describe('events', () => {
       apiCreateRepo(request, {name: repoName, headers: apiUserHeaders(owner)}),
       loginUser(page, owner),
     ]);
+    await page.goto('/');
     const badge = page.locator('a.not-mobile .notification_count');
     await expect(badge).toBeHidden();
 
@@ -23,9 +24,6 @@ test.describe('events', () => {
 
     // Wait for the notification badge to appear via server event
     await expect(badge).toBeVisible({timeout: 15000 * timeoutFactor});
-
-    // Cleanup
-    await Promise.all([apiDeleteUser(request, commenter), apiDeleteUser(request, owner)]);
   });
 
   test('stopwatch', async ({page, request}) => {
@@ -34,20 +32,20 @@ test.describe('events', () => {
 
     await apiCreateUser(request, name);
 
-    // Create repo, issue, and start stopwatch before login
-    await apiCreateRepo(request, {name, headers});
-    await apiCreateIssue(request, name, name, {title: 'events stopwatch test', headers});
-    await apiStartStopwatch(request, name, name, 1, {headers});
-
-    // Login — page renders with the active stopwatch element
-    await loginUser(page, name);
+    // Login in parallel with repo+issue+stopwatch setup (all independent after user exists)
+    await Promise.all([
+      loginUser(page, name),
+      (async () => {
+        await apiCreateRepo(request, {name, headers});
+        await apiCreateIssue(request, name, name, {title: 'events stopwatch test', headers});
+        await apiStartStopwatch(request, name, name, 1, {headers});
+      })(),
+    ]);
+    await page.goto('/');
 
     // Verify stopwatch is visible and links to the correct issue
     const stopwatch = page.locator('.active-stopwatch.not-mobile');
     await expect(stopwatch).toBeVisible();
-
-    // Cleanup
-    await apiDeleteUser(request, name);
   });
 
   test('logout propagation', async ({browser, request}) => {
@@ -75,8 +73,5 @@ test.describe('events', () => {
     await expect(page2.getByRole('link', {name: 'Sign In'})).toBeVisible();
 
     await context.close();
-
-    // Cleanup
-    await apiDeleteUser(request, name);
   });
 });

tests/e2e/external-render.test.ts

@@ -1,6 +1,6 @@
 import {env} from 'node:process';
 import {expect, test} from '@playwright/test';
-import {login, apiCreateRepo, apiCreateFile, apiDeleteRepo, assertFlushWithParent, assertNoJsError, randomString} from './utils.ts';
+import {login, apiCreateRepo, apiCreateFile, assertFlushWithParent, assertNoJsError, randomString} from './utils.ts';
 
 test('external file', async ({page, request}) => {
   const repoName = `e2e-external-render-${randomString(8)}`;
@@ -9,19 +9,15 @@ test('external file', async ({page, request}) => {
     apiCreateRepo(request, {name: repoName}),
     login(page),
   ]);
-  try {
-    await apiCreateFile(request, owner, repoName, 'test.external', '<p>rendered content</p>');
-    await page.goto(`/${owner}/${repoName}/src/branch/main/test.external`);
-    const iframe = page.locator('iframe.external-render-iframe');
-    await expect(iframe).toBeVisible();
-    await expect(iframe).toHaveAttribute('data-src', new RegExp(`/${owner}/${repoName}/render/branch/main/test\\.external`));
-    const frame = page.frameLocator('iframe.external-render-iframe');
-    await expect(frame.locator('p')).toContainText('rendered content');
-    await assertFlushWithParent(iframe, page.locator('.file-view'));
-    await assertNoJsError(page);
-  } finally {
-    await apiDeleteRepo(request, owner, repoName);
-  }
+  await apiCreateFile(request, owner, repoName, 'test.external', '<p>rendered content</p>');
+  await page.goto(`/${owner}/${repoName}/src/branch/main/test.external`);
+  const iframe = page.locator('iframe.external-render-iframe');
+  await expect(iframe).toBeVisible();
+  await expect(iframe).toHaveAttribute('data-src', new RegExp(`/${owner}/${repoName}/render/branch/main/test\\.external`));
+  const frame = page.frameLocator('iframe.external-render-iframe');
+  await expect(frame.locator('p')).toContainText('rendered content');
+  await assertFlushWithParent(iframe, page.locator('.file-view'));
+  await assertNoJsError(page);
 });
 
 test('openapi file', async ({page, request}) => {
@@ -31,31 +27,27 @@ test('openapi file', async ({page, request}) => {
     apiCreateRepo(request, {name: repoName}),
     login(page),
   ]);
-  try {
-    const title = 'Test <API> & "quoted"';
-    const spec = JSON.stringify({
-      openapi: '3.0.0',
-      info: {title, version: '1.0'},
-      paths: {'/pets': {get: {responses: {'200': {description: 'OK', content: {'application/json': {schema: {$ref: '#/components/schemas/Pet'}}}}}}}},
-      components: {schemas: {Pet: {type: 'object', properties: {children: {type: 'array', items: {$ref: '#/components/schemas/Pet'}}}}}},
-    });
-    await apiCreateFile(request, owner, repoName, 'openapi.json', spec);
-    await page.goto(`/${owner}/${repoName}/src/branch/main/openapi.json`);
-    const iframe = page.locator('iframe.external-render-iframe');
-    await expect(iframe).toBeVisible();
-    const viewer = page.frameLocator('iframe.external-render-iframe').locator('#frontend-render-viewer');
-    await expect(viewer.locator('.swagger-ui')).toBeVisible();
-    await expect(viewer.locator('.info .title')).toContainText(title);
-    // expanding the operation triggers swagger-ui's $ref resolver, which fetches window.location
-    // (about:srcdoc since the iframe is loaded via srcdoc); failure surfaces as "Could not resolve reference"
-    await viewer.locator('.opblock-tag').first().click();
-    await viewer.locator('.opblock').first().click();
-    await expect(viewer.getByText('Could not resolve reference')).toHaveCount(0);
-    // poll: postMessage resize may not have settled yet when the visibility checks pass
-    await expect.poll(async () => (await iframe.boundingBox())!.height).toBeGreaterThan(300);
-    await assertFlushWithParent(iframe, page.locator('.file-view'));
-    await assertNoJsError(page);
-  } finally {
-    await apiDeleteRepo(request, owner, repoName);
-  }
+  const title = 'Test <API> & "quoted"';
+  const spec = JSON.stringify({
+    openapi: '3.0.0',
+    info: {title, version: '1.0'},
+    paths: {'/pets': {get: {responses: {'200': {description: 'OK', content: {'application/json': {schema: {$ref: '#/components/schemas/Pet'}}}}}}}},
+    components: {schemas: {Pet: {type: 'object', properties: {children: {type: 'array', items: {$ref: '#/components/schemas/Pet'}}}}}},
+  });
+  await apiCreateFile(request, owner, repoName, 'openapi.json', spec);
+  await page.goto(`/${owner}/${repoName}/src/branch/main/openapi.json`);
+  const iframe = page.locator('iframe.external-render-iframe');
+  await expect(iframe).toBeVisible();
+  const viewer = page.frameLocator('iframe.external-render-iframe').locator('#frontend-render-viewer');
+  await expect(viewer.locator('.swagger-ui')).toBeVisible();
+  await expect(viewer.locator('.info .title')).toContainText(title);
+  // expanding the operation triggers swagger-ui's $ref resolver, which fetches window.location
+  // (about:srcdoc since the iframe is loaded via srcdoc); failure surfaces as "Could not resolve reference"
+  await viewer.locator('.opblock-tag').first().click();
+  await viewer.locator('.opblock').first().click();
+  await expect(viewer.getByText('Could not resolve reference')).toHaveCount(0);
+  // poll: postMessage resize may not have settled yet when the visibility checks pass
+  await expect.poll(async () => (await iframe.boundingBox())!.height).toBeGreaterThan(300);
+  await assertFlushWithParent(iframe, page.locator('.file-view'));
+  await assertNoJsError(page);
 });

tests/e2e/file-view-render.test.ts

@@ -1,49 +1,41 @@
 import {env} from 'node:process';
 import {expect, test} from '@playwright/test';
-import {apiCreateBranch, apiCreateRepo, apiCreateFile, apiDeleteRepo, assertFlushWithParent, assertNoJsError, login, randomString} from './utils.ts';
+import {apiCreateRepo, apiCreateFile, assertFlushWithParent, assertNoJsError, login, randomString} from './utils.ts';
 
 test('3d model file', async ({page, request}) => {
   const repoName = `e2e-3d-render-${randomString(8)}`;
   const owner = env.GITEA_TEST_E2E_USER;
   await apiCreateRepo(request, {name: repoName});
-  try {
-    const stl = 'solid test\nfacet normal 0 0 1\nouter loop\nvertex 0 0 0\nvertex 1 0 0\nvertex 0 1 0\nendloop\nendfacet\nendsolid test\n';
-    await apiCreateFile(request, owner, repoName, 'test.stl', stl);
-    await page.goto(`/${owner}/${repoName}/src/branch/main/test.stl?display=rendered`);
-    const iframe = page.locator('iframe.external-render-iframe');
-    await expect(iframe).toBeVisible();
-    const frame = page.frameLocator('iframe.external-render-iframe');
-    const viewer = frame.locator('#frontend-render-viewer');
-    await expect(viewer.locator('canvas')).toBeVisible();
-    expect((await viewer.boundingBox())!.height).toBeGreaterThan(300);
-    await assertFlushWithParent(iframe, page.locator('.file-view'));
-    // bgcolor passed via gitea-iframe-bgcolor; 3D viewer reads it from body bgcolor — must match parent
-    const [parentBg, iframeBg] = await Promise.all([
-      page.evaluate(() => getComputedStyle(document.body).backgroundColor),
-      frame.locator('body').evaluate((el) => getComputedStyle(el).backgroundColor),
-    ]);
-    expect(iframeBg).toBe(parentBg);
-    await assertNoJsError(page);
-  } finally {
-    await apiDeleteRepo(request, owner, repoName);
-  }
+  const stl = 'solid test\nfacet normal 0 0 1\nouter loop\nvertex 0 0 0\nvertex 1 0 0\nvertex 0 1 0\nendloop\nendfacet\nendsolid test\n';
+  await apiCreateFile(request, owner, repoName, 'test.stl', stl);
+  await page.goto(`/${owner}/${repoName}/src/branch/main/test.stl?display=rendered`);
+  const iframe = page.locator('iframe.external-render-iframe');
+  await expect(iframe).toBeVisible();
+  const frame = page.frameLocator('iframe.external-render-iframe');
+  const viewer = frame.locator('#frontend-render-viewer');
+  await expect(viewer.locator('canvas')).toBeVisible();
+  expect((await viewer.boundingBox())!.height).toBeGreaterThan(300);
+  await assertFlushWithParent(iframe, page.locator('.file-view'));
+  // bgcolor passed via gitea-iframe-bgcolor; 3D viewer reads it from body bgcolor — must match parent
+  const [parentBg, iframeBg] = await Promise.all([
+    page.evaluate(() => getComputedStyle(document.body).backgroundColor),
+    frame.locator('body').evaluate((el) => getComputedStyle(el).backgroundColor),
+  ]);
+  expect(iframeBg).toBe(parentBg);
+  await assertNoJsError(page);
 });
 
 test('pdf file', async ({page, request}) => {
   // headless playwright cannot render PDFs (PDFObject.embed returns false), so this is a limited test
   const repoName = `e2e-pdf-render-${randomString(8)}`;
   const owner = env.GITEA_TEST_E2E_USER;
   await apiCreateRepo(request, {name: repoName});
-  try {
-    await apiCreateFile(request, owner, repoName, 'test.pdf', '%PDF-1.0\n%%EOF\n');
-    await page.goto(`/${owner}/${repoName}/src/branch/main/test.pdf`);
-    const container = page.locator('.file-view-render-container');
-    await expect(container).toHaveAttribute('data-render-name', 'pdf-viewer');
-    expect((await container.boundingBox())!.height).toBeGreaterThan(300);
-    await assertFlushWithParent(container, page.locator('.file-view'));
-  } finally {
-    await apiDeleteRepo(request, owner, repoName);
-  }
+  await apiCreateFile(request, owner, repoName, 'test.pdf', '%PDF-1.0\n%%EOF\n');
+  await page.goto(`/${owner}/${repoName}/src/branch/main/test.pdf`);
+  const container = page.locator('.file-view-render-container');
+  await expect(container).toHaveAttribute('data-render-name', 'pdf-viewer');
+  expect((await container.boundingBox())!.height).toBeGreaterThan(300);
+  await assertFlushWithParent(container, page.locator('.file-view'));
 });
 
 test('asciicast file', async ({page, request}) => {
@@ -54,16 +46,12 @@ test('asciicast file', async ({page, request}) => {
   const branch = '日本語-branch';
   const branchEnc = encodeURIComponent(branch);
   await Promise.all([apiCreateRepo(request, {name: repoName, autoInit: false}), login(page)]);
-  try {
-    const cast = '{"version": 2, "width": 80, "height": 24}\n[0.0, "o", "hi"]\n';
-    await apiCreateFile(request, owner, repoName, 'readme.cast', cast);
-    await apiCreateBranch(request, owner, repoName, branch);
-    await page.goto(`/${owner}/${repoName}/src/branch/${branchEnc}`);
-    const container = page.locator('.asciinema-player-container');
-    await expect(container).toHaveAttribute('data-asciinema-player-src', `/${owner}/${repoName}/raw/branch/${branchEnc}/readme.cast`);
-    await expect(container.locator('.ap-wrapper')).toBeVisible();
-    expect((await container.boundingBox())!.height).toBeGreaterThan(300);
-  } finally {
-    await apiDeleteRepo(request, owner, repoName);
-  }
+  const cast = '{"version": 2, "width": 80, "height": 24}\n[0.0, "o", "hi"]\n';
+  // on an empty repo, apiCreateFile with newBranch creates that branch as the initial commit
+  await apiCreateFile(request, owner, repoName, 'readme.cast', cast, {newBranch: branch});
+  await page.goto(`/${owner}/${repoName}/src/branch/${branchEnc}`);
+  const container = page.locator('.asciinema-player-container');
+  await expect(container).toHaveAttribute('data-asciinema-player-src', `/${owner}/${repoName}/raw/branch/${branchEnc}/readme.cast`);
+  await expect(container.locator('.ap-wrapper')).toBeVisible();
+  expect((await container.boundingBox())!.height).toBeGreaterThan(300);
 });

tests/e2e/issue-project.test.ts

@@ -1,6 +1,6 @@
 import {env} from 'node:process';
 import {test, expect} from '@playwright/test';
-import {login, apiCreateRepo, apiCreateIssue, apiDeleteRepo, createProjectColumn, randomString} from './utils.ts';
+import {login, apiCreateRepo, apiCreateIssue, createProjectColumn, randomString} from './utils.ts';
 
 test('assign issue to project and change column', async ({page}) => {
   const repoName = `e2e-issue-project-${randomString(8)}`;
@@ -26,5 +26,4 @@ test('assign issue to project and change column', async ({page}) => {
   await columnCombo.locator('.ui.dropdown').click();
   await columnCombo.locator('.menu a.item', {hasText: 'In Progress'}).click();
   await expect(columnCombo.getByTestId('sidebar-project-column-text')).toHaveText('In Progress');
-  await apiDeleteRepo(page.request, user, repoName);
 });

tests/e2e/login.test.ts

@@ -1,12 +1,17 @@
+import {env} from 'node:process';
 import {test, expect} from '@playwright/test';
-import {login, logout} from './utils.ts';
+import {logout} from './utils.ts';
 
 test('homepage', async ({page}) => {
   await page.goto('/');
   await expect(page.getByRole('img', {name: 'Logo'})).toHaveAttribute('src', '/assets/img/logo.svg');
 });
 
-test('login and logout', async ({page}) => {
-  await login(page);
+test('login form and logout', async ({page}) => {
+  await page.goto('/user/login');
+  await page.getByLabel('Username or Email Address').fill(env.GITEA_TEST_E2E_USER);
+  await page.getByLabel('Password').fill(env.GITEA_TEST_E2E_PASSWORD);
+  await page.getByRole('button', {name: 'Sign In'}).click();
+  await expect(page.getByRole('link', {name: 'Sign In'})).toBeHidden();
   await logout(page);
 });

tests/e2e/milestone.test.ts

@@ -1,6 +1,6 @@
 import {env} from 'node:process';
 import {test, expect} from '@playwright/test';
-import {login, apiCreateRepo, apiDeleteRepo, randomString} from './utils.ts';
+import {login, apiCreateRepo, randomString} from './utils.ts';
 
 test('create a milestone', async ({page}) => {
   const repoName = `e2e-milestone-${randomString(8)}`;
@@ -9,5 +9,4 @@ test('create a milestone', async ({page}) => {
   await page.getByPlaceholder('Title').fill('Test Milestone');
   await page.getByRole('button', {name: 'Create Milestone'}).click();
   await expect(page.locator('.milestone-list')).toContainText('Test Milestone');
-  await apiDeleteRepo(page.request, env.GITEA_TEST_E2E_USER, repoName);
 });