Skip to content

Fix Mermaid diagrams failing when node labels contain line breaks #37296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 3 commits into from
Apr 19, 2026
Merged

Fix Mermaid diagrams failing when node labels contain line breaks #37296

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07ffa02
disable html tags which break rendering
bircni Apr 19, 2026
bb25bd1
fix
wxiaoguang Apr 19, 2026
501460e
fix lint
wxiaoguang Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions web_src/js/markup/mermaid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ export async function initMarkupCodeMermaid(elMarkup: HTMLElement): Promise<void
theme: isDarkTheme() ? 'dark' : 'neutral', // TODO: maybe it should use "darkMode" to adopt more user-specified theme instead of just "dark" or "neutral"
securityLevel: 'strict',
suppressErrorRendering: true,
// HTML labels embed foreignObject content (e.g. <br> for line breaks) that is not well-formed XML;
// we parse the SVG string with DOMParser as image/svg+xml before inserting it (see #37295, mermaid-js/mermaid#1766).
htmlLabels: false,
});

const iframeStyleText = getIframeCss();
Expand Down