Fix flaky TestCatFileBatch/QueryTerminated test (#37159)#37178
Merged
silverwind merged 1 commit intogo-gitea:release/v1.26from Apr 11, 2026
Merged
Fix flaky TestCatFileBatch/QueryTerminated test (#37159)#37178silverwind merged 1 commit intogo-gitea:release/v1.26from
TestCatFileBatch/QueryTerminated test (#37159)#37178silverwind merged 1 commit intogo-gitea:release/v1.26from
Conversation
`TestCatFileBatch/QueryTerminated` relied on timing to distinguish `os.ErrClosed` vs `io.EOF` error paths. Replace `time.Sleep`-based synchronization with a channel-based hook on pipe close, making both error paths fully deterministic regardless of CI runner speed. Ref: https://github.com/go-gitea/gitea/actions/runs/24193070536/job/70615366804 Co-authored-by: Claude (Opus 4.6) <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Apr 11, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Apr 11, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37159 by @silverwind
TestCatFileBatch/QueryTerminatedrelied on timing to distinguishos.ErrClosedvsio.EOFerror paths. Replacetime.Sleep-based synchronization with a channel-based hook on pipe close, making both error paths fully deterministic regardless of CI runner speed.Ref: https://github.com/go-gitea/gitea/actions/runs/24193070536/job/70615366804
This PR was written with the help of Claude Opus 4.6