Remove unneeded doctor sub-commands

[wxiaoguang]

No description provided.

[wxiaoguang]

Explained my understanding in the comments. Feel free to correct if I was wrong.

[Copilot]

Pull request overview

This PR removes several previously available doctor checks/sub-commands and their supporting code (including related model helpers and test fixtures), aiming to simplify the services/doctor surface area.

Changes:

• Removed multiple doctor checks (paths/config validation, DB version check, merge base recalculation, historical fix16961 repair, user type repair, actions unfinished-run-status repair, and “breaking” username/email checks).
• Cleaned up related helper functions and tests/fixtures that only supported those checks.
• Updated actions run count expectations after removing action run fixtures tied to the deleted doctor check.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
services/doctor/usertype.go	Removed the “wrong user type” doctor check registration and implementation.
services/doctor/paths.go	Removed the configuration/paths doctor check (previously default + DB-skip).
services/doctor/misc.go	Removed “script-type” and “enable-push-options” checks and related imports/registrations.
services/doctor/mergebase.go	Removed PR merge-base recalculation check.
services/doctor/fix16961.go	Removed legacy dump-repair check for issue #16961.
services/doctor/fix16961_test.go	Removed tests that only covered the deleted fix16961 behavior.
services/doctor/dbversion.go	Removed doctor check that ensured/migrated DB version.
services/doctor/breaking.go	Removed optional checks for invalid user emails/usernames.
services/doctor/actions.go	Removed “fix unfinished actions run status” check; kept mirror-actions-unit check.
services/doctor/actions_test.go	Removed test that only covered the deleted actions doctor check.
models/user/user.go	Removed user model helpers that were only used by the deleted usertype doctor check.
models/fixtures/action_task.yml	Removed fixture row associated with deleted actions doctor test data.
models/fixtures/action_run.yml	Removed fixture run associated with deleted actions doctor test data.
models/fixtures/action_run_job.yml	Removed fixture job associated with deleted actions doctor test data.
models/actions/run_test.go	Updated expectations for NumActionRuns after fixture removal.

Comments suppressed due to low confidence (1)

services/doctor/misc.go:203

• With the removal of the former "paths" check, there no longer appears to be any doctor check that sets SkipDatabaseInitialization=true. As a result, RunChecks will initialize DB/Git before running the first check; initDBSkipLogger calls setting.MustInstalled(), which uses log.Fatal and can terminate the process immediately for uninstalled/misconfigured instances (bypassing doctor’s normal error reporting). Consider reintroducing a minimal early configuration/paths check (SkipDatabaseInitialization=true, AbortIfFailed=true) or refactoring RunChecks/initDBSkipLogger to validate config/InstallLock without log.Fatal and return an error instead.

func init() {
	Register(&Check{
		Title:     "Check if hook files are up-to-date and executable",
		Name:      "hooks",
		IsDefault: false,
		Run:       checkHooks,
		Priority:  6,
	})

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[silverwind]

Add a breaking label? Or too unimportant?

[wxiaoguang]

Or too unimportant?