Update Combine method to treat warnings as failures and adjust tests (#37048)#37075
Merged
lunny merged 1 commit intogo-gitea:release/v1.25from Apr 1, 2026
Merged
Conversation
…o-gitea#37048) Treat Commit Status Warnings as errors > The root problem is that the definition of "warning" are different across systems. > > * Sometimes, "warning" is treated as "acceptable" (Gitea 1.25) > * Sometimes, "warning" is mapped from "Result.UNSTABLE", which means "there are test failures" and it is "failure" in Gitea > > **To avoid breaking existing users, the best choice is to revert the behavior on Gitea side: treat "warning" as "error".** go-gitea#37042 (comment) fixes go-gitea#37042 --------- Signed-off-by: Nicolas <bircni@icloud.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Apr 1, 2026
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Apr 1, 2026
GiteaBot
added
lgtm/done
Member
|
Why back port this? |
Member
|
Because it fixes a regression introduced in 1.25, which breaks jenkins integration. |
bircni
approved these changes
Apr 1, 2026
Contributor
TBH it needs to "push" to make it release sooner, otherwise it will never be released. |
Member
|
I'm a strong proponent of fixed and predictable release cycles, but so far the owners have not followed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37048 by @bircni
Treat Commit Status Warnings as errors
#37042 (comment)
fixes #37042