Fix user settings sidebar showing disabled features on some pages#36958
Merged
lunny merged 4 commits intogo-gitea:mainfrom Mar 23, 2026
Merged
Fix user settings sidebar showing disabled features on some pages#36958lunny merged 4 commits intogo-gitea:mainfrom
lunny merged 4 commits intogo-gitea:mainfrom
Conversation
Move UserDisabledFeatures context data into a shared SettingsCtxData middleware for the /user/settings route group, so it is set consistently on all pages (including Notifications, Actions, etc.) instead of only on the handlers that remembered to set it individually. Fixes go-gitea#36954
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Mar 23, 2026
wxiaoguang
approved these changes
Mar 23, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 23, 2026
GiteaBot
added
lgtm/done
lunny
added
type/bug
backport/v1.25
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 23, 2026
…-gitea#36958) Move UserDisabledFeatures context data into a shared SettingsCtxData middleware for the /user/settings route group, so it is set consistently on all pages (including Notifications, Actions, etc.) instead of only on the handlers that remembered to set it individually. Fixes go-gitea#36954
silverwind
pushed a commit
that referenced
this pull request
Mar 24, 2026
…6958) (#36969) Backport #36958 by @bircni Move UserDisabledFeatures context data into a shared SettingsCtxData middleware for the /user/settings route group, so it is set consistently on all pages (including Notifications, Actions, etc.) instead of only on the handlers that remembered to set it individually. Fixes #36954 Co-authored-by: Nicolas <bircni@icloud.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 24, 2026
* giteaofficial/main: [skip ci] Updated translations via Crowdin Make PUBLIC_URL_DETECTION default to "auto" (go-gitea#36955) Fix user settings sidebar showing disabled features on some pages (go-gitea#36958) Update GitHub Actions to latest major versions (go-gitea#36964) Fix various trivial problems (go-gitea#36953) Rework checkbox styling, remove `input` border hover effect (go-gitea#36870) Add `DEFAULT_DELETE_BRANCH_AFTER_MERGE` setting (go-gitea#36917) Update Nix flake (go-gitea#36943) Update to eslint 10 (go-gitea#36925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move UserDisabledFeatures context data into a shared SettingsCtxData middleware for the /user/settings route group, so it is set consistently on all pages (including Notifications, Actions, etc.) instead of only on the handlers that remembered to set it individually.
Fixes #36954