Bound PageSize in ListUnadoptedRepositories#36884
Merged
lunny merged 2 commits intogo-gitea:mainfrom Mar 13, 2026
Merged
Conversation
Add SetDefaultValues() call to ensure PageSize is bounded, preventing potential excessive memory allocation from unbounded pagination parameters. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens ListUnadoptedRepositories against unbounded pagination input by applying db.ListOptions defaulting/bounding before using PageSize for slice capacity calculations, addressing a CodeQL alert about potential excessive memory allocation.
Changes:
- Call
opts.SetDefaultValues()at the start ofListUnadoptedRepositoriesto clampPageSizeand normalizePage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
silverwind
changed the title
ListUnadoptedRepositories
silverwind
added
the
topic/security
lafriks
approved these changes
Mar 12, 2026
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 13, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 13, 2026
* giteaofficial/main: Bound PageSize in `ListUnadoptedRepositories` (go-gitea#36884) Fix timeline event layout overflow with long content (go-gitea#36595) [skip ci] Updated translations via Crowdin Replace index with id in actions routes (go-gitea#36842) Enable eslint concurrency (go-gitea#36878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SetDefaultValues()call to ensure PageSize is bounded, preventing potential excessive memory allocation from unbounded pagination parameters.Fixes CodeQL alert #188. All other 49 open alerts were false-positives and are dismissed with appropriate comments.