Migrate fomantic search and modal CSS to first-party modules#36869
Merged
delvh merged 6 commits intogo-gitea:mainfrom Mar 17, 2026
Merged
Migrate fomantic search and modal CSS to first-party modules#36869delvh merged 6 commits intogo-gitea:mainfrom
search and modal CSS to first-party modules#36869delvh merged 6 commits intogo-gitea:mainfrom
Conversation
Replace the fomantic search.css (520 lines) with a minimal first-party module (80 lines) containing only the rules actually used. Hardcoded colors are replaced with theme variables, and the base.css overrides are merged directly into the new module. Eliminated unused CSS for: category search, selection search, loading spinner, disabled state, scrolling/long/short variations, left/right alignment, all size variants, price display, message display, and action buttons. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/refactoring
Replace the fomantic modal.css (698 lines) with a minimal first-party module (329 lines) containing only the rules actually used. Hardcoded colors are replaced with theme variables, and the base.css overrides are merged directly into the new module. Eliminated unused CSS for: basic modal, legacy modal positioning, inverted dimmer coupling, aligned variations, undetached scrolling, overlay fullscreen, image content/description layout, all large size variants (large/big/huge/massive), loading state, scrolling content, and vendor-prefixed user-select. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
silverwind
changed the title
silverwind
changed the title
search and modal CSS to first-party modules
No fomantic CSS components remain, so remove the empty file and its webpack entry point. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
lunny
approved these changes
Mar 9, 2026
GiteaBot
added
lgtm/need 1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the remaining Fomantic-provided search and modal CSS from the frontend bundle and replaces it with first-party CSS modules containing only the rules needed by the app, using theme variables for colors and consolidating prior base overrides.
Changes:
- Remove
web_src/fomantic/build/fomantic.cssfrom the webpack entry and stop building Fomanticmodal/searchCSS components. - Add a new first-party
web_src/css/modules/search.cssmodule and import it fromweb_src/css/index.css. - Expand
web_src/css/modules/modal.cssto include the required (previously Fomantic-provided) modal styling, and remove related overrides fromweb_src/css/base.css.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.ts | Drops fomantic.css from the main CSS bundle entry. |
| web_src/fomantic/semantic.json | Removes Fomantic modal/search components from the build config. |
| web_src/fomantic/build/fomantic.css | Removes imports for the deleted Fomantic CSS components (file becomes empty). |
| web_src/fomantic/build/components/search.css | Deletes upstream Fomantic search CSS. |
| web_src/fomantic/build/components/modal.css | Deletes upstream Fomantic modal CSS. |
| web_src/css/modules/search.css | New minimal first-party search styling. |
| web_src/css/modules/modal.css | Incorporates required modal styling into the first-party module. |
| web_src/css/index.css | Imports the new search module. |
| web_src/css/base.css | Removes search-related overrides and updates modal z-index comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Restore transform-origin: center top on .ui.search > .results to preserve the fomantic transition module scale animation origin. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
TheFox0x7
approved these changes
Mar 16, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
Mar 17, 2026
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 17, 2026
* origin/main: Update Nix flake (go-gitea#36902) Migrate fomantic `search` and `modal` CSS to first-party modules (go-gitea#36869) Feature: Add per-runner “Disable/Pause” (go-gitea#36776) # Conflicts: # webpack.config.ts
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 17, 2026
The fomantic CSS was migrated to first-party modules in go-gitea#36869, but the import in index-domready.ts was left behind after merge. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 18, 2026
* giteaofficial/main: [skip ci] Updated translations via Crowdin Update Nix flake (go-gitea#36902) Migrate fomantic `search` and `modal` CSS to first-party modules (go-gitea#36869) Feature: Add per-runner “Disable/Pause” (go-gitea#36776) Enable native dark mode for swagger-ui (go-gitea#36899) Front port changelog for 1.25.5 (go-gitea#36892) Fix typos in code comments: doesnt, dont, wont (go-gitea#36890) Vendor relative-time-element as local web component (go-gitea#36853)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the fomantic search.css (520 lines) and modal.css (698 lines) with minimal first-party modules containing only the rules actually used. Hardcoded colors are replaced with theme variables, and the base.css overrides are merged directly into the new modules.
With this change, all original Fomantic CSS is now gone.
search.css: 520 → 85 lines
modal.css: 698 → 329 lines