Skip to content

Clean up refreshViewedFilesSummary #36868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 6 commits into from
Mar 8, 2026
Merged

Clean up refreshViewedFilesSummary #36868

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9297df5
Fix CodeQL js/xss-through-dom alert in pull-view-file.ts
silverwind Mar 8, 2026
ef5100f
Add braces to if body
silverwind Mar 8, 2026
1373890
Remove contradictory non-null assertion on summaryLabel
silverwind Mar 8, 2026
02af86b
Remove redundant null checks in refreshViewedFilesSummary
silverwind Mar 8, 2026
a33afda
Remove outdated "if present" from comment
silverwind Mar 8, 2026
d9849e1
Merge branch 'main' into fix-170
lunny Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web_src/js/features/pull-view-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ const viewedCheckboxSelector = '.viewed-file-form'; // Selector under which all
const expandFilesBtnSelector = '#expand-files-btn';
const collapseFilesBtnSelector = '#collapse-files-btn';

// Refreshes the summary of viewed files if present
// Refreshes the summary of viewed files
Comment thread
wxiaoguang marked this conversation as resolved.
// The data used will be window.config.pageData.prReview.numberOf{Viewed}Files
function refreshViewedFilesSummary() {
const viewedFilesProgress = document.querySelector('#viewed-files-summary');
viewedFilesProgress?.setAttribute('value', prReview.numberOfViewedFiles);
const summaryLabel = document.querySelector('#viewed-files-summary-label')!;
if (summaryLabel) summaryLabel.innerHTML = summaryLabel.getAttribute('data-text-changed-template')!
const viewedFilesProgress = document.querySelector('#viewed-files-summary')!;
viewedFilesProgress.setAttribute('value', prReview.numberOfViewedFiles);
const summaryLabel = document.querySelector<HTMLElement>('#viewed-files-summary-label')!;
summaryLabel.textContent = summaryLabel.getAttribute('data-text-changed-template')!
.replace('%[1]d', prReview.numberOfViewedFiles)
.replace('%[2]d', prReview.numberOfFiles);
}
Expand Down