Skip to content

[WIP] Review changed behaviors in routers/web/auth package#36865

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/review-auth-package-changes
Closed

[WIP] Review changed behaviors in routers/web/auth package#36865
Copilot wants to merge 1 commit intomainfrom
copilot/review-auth-package-changes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 8, 2026

  • Add prepareCommonAuthPageData to routers/web/auth/auth.go
  • Update prepareSignInPageData, SignUp, SignUpPost to use the new function
  • Add prepareLinkAccountPageData to routers/web/auth/linkaccount.go
  • Update LinkAccount, LinkAccountPostSignIn, LinkAccountPostRegister to use it
  • Add prepareConnectOpenIDPageData and prepareRegisterOpenIDPageData to routers/web/auth/openid.go
  • Update ConnectOpenID, ConnectOpenIDPost, RegisterOpenID, RegisterOpenIDPost to use them
  • Update templates/user/auth/captcha.tmpl to use RecaptchaAPIScriptURL
  • Remove SetCaptchaData from services/context/captcha.go (no longer needed)
  • Fix Case 1 bug: AllowOnlyInternalRegistration should be set for ConnectOpenIDPost (fixed by new helper)
  • Fix Case 2 bug: sign-in page should not have DisableRegistration/EnableOpenIDSignUp/AllowOnlyInternalRegistration set unnecessarily
  • Run tests and lint

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2026
@wxiaoguang wxiaoguang closed this Mar 8, 2026
Copilot stopped work on behalf of wxiaoguang due to an error March 8, 2026 11:31
@wxiaoguang wxiaoguang deleted the copilot/review-auth-package-changes branch April 8, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants