Fix OAuth2 authorization code expiry and reuse handling (#36797)#36851
Merged
lunny merged 1 commit intogo-gitea:release/v1.25from Mar 6, 2026
Merged
Fix OAuth2 authorization code expiry and reuse handling (#36797)#36851lunny merged 1 commit intogo-gitea:release/v1.25from
lunny merged 1 commit intogo-gitea:release/v1.25from
Conversation
- set OAuth2 authorization code `ValidUntil` on creation and add expiry checks during exchange - return a specific error when codes are invalidated twice to prevent concurrent reuse - add unit tests covering validity timestamps, expiration, and double invalidation --- Generate by a coding agent with Codex 5.2 --------- Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Mar 6, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 6, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36797 by @lunny
ValidUntilon creation and add expiry checks during exchangeGenerate by a coding agent with Codex 5.2