Skip to content

Fix CSS stacking context issue in actions log#36749

Merged
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:cssstack
Feb 26, 2026
Merged

Fix CSS stacking context issue in actions log#36749
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:cssstack

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Feb 25, 2026

ansi_up sets opacity:.7 on faint text which causes a CSS stacking context to be created that results in all "faint" elements rendering above the header:

Screenshot 2026-02-25 at 16 42 57

Fix it by adding a z-index to the header so it also has its own stacking context and renders above:

Screenshot 2026-02-25 at 16 42 41

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2026
@silverwind silverwind added topic/gitea-actions related to the actions of Gitea type/bug labels Feb 25, 2026
@silverwind silverwind requested a review from Copilot February 25, 2026 16:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CSS rendering issue where faint ANSI text in action logs was appearing above the sticky job step summary header. The issue was caused by ansi_up library applying opacity: 0.7 to faint text, which creates a new CSS stacking context, causing those elements to render above the sticky header that didn't have an explicit z-index.

Changes:

  • Added z-index: 1 to .job-step-summary.selected sticky element to establish a stacking context that renders above ANSI-styled log content

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@silverwind silverwind changed the title Fix faint text CSS stacking context issue in actions log Fix CSS stacking context issue in actions log Feb 26, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2026
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 26, 2026
@silverwind silverwind enabled auto-merge (squash) February 26, 2026 21:05
@silverwind silverwind merged commit f109b97 into go-gitea:main Feb 26, 2026
26 checks passed
@silverwind silverwind deleted the cssstack branch February 26, 2026 22:35
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 26, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 26, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2026
* giteaofficial/main:
  Filter out untracked files from spellchecking (go-gitea#36756)
  Fix CSS stacking context issue in actions log (go-gitea#36749)
  Fix milestone/project text overflow in issue sidebar (go-gitea#36741)
  Update tool dependencies and fix new lint issues (go-gitea#36702)
  Instance-wide (global) info banner and maintenance mode (go-gitea#36571)
  Add created_by filter to SearchIssues (go-gitea#36670)
  Inline and lazy-load EasyMDE CSS, fix border colors (go-gitea#36714)
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 27, 2026
* origin/main:
  Move Fomantic dropdown CSS to custom module (go-gitea#36530)
  Use "Enable Gravatar" but not "Disable" (go-gitea#36771)
  feat: add branch_count to repository API (go-gitea#35351) (go-gitea#36743)
  Deprecate RenderWithErr (go-gitea#36769)
  Lazy-load some Vue components, fix heatmap chunk loading on every page (go-gitea#36719)
  Filter out untracked files from spellchecking (go-gitea#36756)
  Fix CSS stacking context issue in actions log (go-gitea#36749)
  Fix milestone/project text overflow in issue sidebar (go-gitea#36741)
  Update tool dependencies and fix new lint issues (go-gitea#36702)
  Instance-wide (global) info banner and maintenance mode (go-gitea#36571)
  Add created_by filter to SearchIssues (go-gitea#36670)
  Inline and lazy-load EasyMDE CSS, fix border colors (go-gitea#36714)

# Conflicts:
#	templates/repo/issue/view_content/pull_merge_box.tmpl
#	web_src/js/features/repo-issue-pull.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend topic/gitea-actions related to the actions of Gitea type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants