Fix release draft access check logic#36720
Merged
lunny merged 5 commits intogo-gitea:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
wxiaoguang
commented
Feb 23, 2026
wxiaoguang
commented
- remove hasRepoWriteScope to avoid abuse
- clarify "ctx.Written" behavior
- merge "read-only" tests to slightly improve performance
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
wxiaoguang
added
the
skip-changelog
lunny
approved these changes
Feb 23, 2026
GiteaBot
added
lgtm/need 1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts draft-release access checks in the API to avoid improper draft visibility via token scope handling, and refactors related integration tests to run under a shared test environment setup.
Changes:
- Replace draft-access logic with a consolidated
canAccessReleaseDrafthelper and use it across release and release-attachment API endpoints. - Remove
hasRepoWriteScopeand simplify draft handling to consistently return 404 when drafts aren’t accessible. - Merge several “read” integration tests into a single grouped test to reduce repeated environment setup overhead.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/api_releases_test.go | Groups multiple release read-related API tests under a single PrepareTestEnv run. |
| tests/integration/api_releases_attachment_test.go | Converts standalone tests into helper subtests invoked by the grouped release read test. |
| routers/api/v1/repo/release_attachment.go | Uses the new draft-access helper to gate draft release attachment listing/getting. |
| routers/api/v1/repo/release.go | Introduces canAccessReleaseDraft and uses it to control draft visibility and inclusion in listings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheFox0x7
approved these changes
Feb 25, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 26, 2026
* giteaofficial/main: Fix release draft access check logic (go-gitea#36720) Change image transparency grid to CSS (go-gitea#36711) Avoid opening new tab when downloading actions logs (go-gitea#36740) Add validation constraints for repository creation fields (go-gitea#36671) Fix SVG height calculation in diff viewer (go-gitea#36748)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 26, 2026
* main: (24 commits) Instance-wide (global) info banner and maintenance mode (go-gitea#36571) Add created_by filter to SearchIssues (go-gitea#36670) Inline and lazy-load EasyMDE CSS, fix border colors (go-gitea#36714) Fix release draft access check logic (go-gitea#36720) Change image transparency grid to CSS (go-gitea#36711) Avoid opening new tab when downloading actions logs (go-gitea#36740) Add validation constraints for repository creation fields (go-gitea#36671) Fix SVG height calculation in diff viewer (go-gitea#36748) Fix path resolving (go-gitea#36734) [skip ci] Updated translations via Crowdin Fix track time list permission check (go-gitea#36662) Fix incorrect setting loading order (go-gitea#36735) Use case-insensitive matching for Git error "Not a valid object name" (go-gitea#36728) feat: Add workflow dependencies visualization (go-gitea#36248) Add keyboard shortcuts for repository file and code search (go-gitea#36416) Refactor text utility classes to Tailwind CSS (go-gitea#36703) Prevent redirect bypasses via backslash-encoded paths (go-gitea#36660) Fix force push time-line commit comments of pull request (go-gitea#36653) Fix get release draft permission check (go-gitea#36659) Move `X_FRAME_OPTIONS` setting from `cors` to `security` section (go-gitea#30256) ... # Conflicts: # web_src/css/base.css # web_src/css/index.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.