Skip to content

Change default "allow edits from maintainers" to true #36709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind wants to merge 3 commits into from
Closed

Change default "allow edits from maintainers" to true #36709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75995dc
Change default "allow edits from maintainers" to true
silverwind Feb 22, 2026
abe6bb6
Add migration to set DefaultAllowMaintainerEdit to true
silverwind Feb 22, 2026
5c3187c
Revert "Add migration to set DefaultAllowMaintainerEdit to true"
silverwind Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/issues/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ type PullRequest struct {
HeadCommitID string `xorm:"-"`
BaseBranch string
MergeBase string `xorm:"VARCHAR(64)"`
AllowMaintainerEdit bool `xorm:"NOT NULL DEFAULT false"`
AllowMaintainerEdit bool `xorm:"NOT NULL DEFAULT true"`
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it affects nothing. Need to revert

Copy link
Copy Markdown
Member

@lafriks lafriks Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it affects nothing than default should be removed at all, keeping it different for other settings is worse


HasMerged bool `xorm:"INDEX"`
MergedCommitID string `xorm:"VARCHAR(64)"`
Expand Down
2 changes: 1 addition & 1 deletion routers/api/v1/repo/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ func updateRepoUnits(ctx *context.APIContext, opts api.EditRepoOption) error {
AllowRebaseUpdate: true,
DefaultDeleteBranchAfterMerge: false,
DefaultMergeStyle: repo_model.MergeStyleMerge,
DefaultAllowMaintainerEdit: false,
DefaultAllowMaintainerEdit: true,
}
} else {
config = unit.PullRequestsConfig()
Expand Down
2 changes: 1 addition & 1 deletion routers/web/repo/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ func CompareDiff(ctx *context.Context) {
config := unit.PullRequestsConfig()
ctx.Data["AllowMaintainerEdit"] = config.DefaultAllowMaintainerEdit
} else {
ctx.Data["AllowMaintainerEdit"] = false
ctx.Data["AllowMaintainerEdit"] = true
}

ctx.HTML(http.StatusOK, tplCompare)
Expand Down
2 changes: 1 addition & 1 deletion services/convert/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func innerToRepo(ctx context.Context, repo *repo_model.Repository, permissionInR
autodetectManualMerge := false
defaultDeleteBranchAfterMerge := false
defaultMergeStyle := repo_model.MergeStyleMerge
defaultAllowMaintainerEdit := false
defaultAllowMaintainerEdit := true
defaultTargetBranch := ""
if unit, err := repo.GetUnit(ctx, unit_model.TypePullRequests); err == nil {
config := unit.PullRequestsConfig()
Expand Down