Skip to content

Replace google/go-licenses with custom generation #36575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverwind merged 26 commits into from
Feb 18, 2026
Merged

Replace google/go-licenses with custom generation #36575

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9e42848
Replace google/go-licenses with custom module-cache-based license gen…
silverwind Feb 10, 2026
e3e80f3
Address review: use GO env var and add warnings for file errors
silverwind Feb 10, 2026
2e95d72
Apply suggestion from @silverwind
silverwind Feb 10, 2026
29a3f7d
fmt
silverwind Feb 10, 2026
00c98c4
Merge branch 'main' into golic
silverwind Feb 11, 2026
e497375
Merge branch 'main' into golic
silverwind Feb 12, 2026
0c79471
Filter go-licenses to actual dependencies, restore subdir licenses
silverwind Feb 12, 2026
2226ceb
Fix go-licenses generation to be reproducible across platforms
silverwind Feb 13, 2026
426dfbf
Regenerate go-licenses.json
silverwind Feb 13, 2026
1f49c4b
Add instruction to never force-push to PR branches
silverwind Feb 13, 2026
1204ad2
Combine two go list calls into one for go-licenses generation
silverwind Feb 13, 2026
6c16377
Add instruction to indicate agent authorship in comments
silverwind Feb 13, 2026
0dad051
Update authorship instruction to be more concise
silverwind Feb 13, 2026
ade96cd
Use full "pull request" instead of abbreviation
silverwind Feb 13, 2026
003ac70
Clarify authorship instruction to specify placement at top of comment
silverwind Feb 13, 2026
ec90106
Rename ignoredModulePaths to ignoredNames for accuracy
silverwind Feb 13, 2026
330641f
Merge branch 'main' into golic
silverwind Feb 14, 2026
e95afd5
remove AGENTS.md change
silverwind Feb 14, 2026
9ea9a01
Merge branch 'main' into golic
silverwind Feb 15, 2026
1d03ada
Simplify generate-go-licenses: remove getTrackedFiles and concurrency
silverwind Feb 15, 2026
2f7c74d
Scan package subdirectories for unique licenses, remove findSubdirLic…
silverwind Feb 15, 2026
3be3448
Apply suggestion from @silverwind
silverwind Feb 15, 2026
37eb730
Prefer primary license files over variants to reduce diff
silverwind Feb 15, 2026
369607b
Scan intermediate directories for vendored license files
silverwind Feb 18, 2026
b0ab562
Merge branch 'main' into golic
silverwind Feb 18, 2026
62fc7e7
Merge branch 'main' into golic
GiteaBot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ cpu.out
/vendor
/VERSION
/.air
/.go-licenses

# Files and folders that were previously generated
/public/assets/img/webpack
Expand Down
11 changes: 2 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ GXZ_PACKAGE ?= github.com/ulikunitz/xz/cmd/gxz@v0.5.15
MISSPELL_PACKAGE ?= github.com/golangci/misspell/cmd/misspell@v0.7.0
SWAGGER_PACKAGE ?= github.com/go-swagger/go-swagger/cmd/swagger@v0.33.1
XGO_PACKAGE ?= src.techknowlogick.com/xgo@latest
GO_LICENSES_PACKAGE ?= github.com/google/go-licenses@v1
GOVULNCHECK_PACKAGE ?= golang.org/x/vuln/cmd/govulncheck@v1
ACTIONLINT_PACKAGE ?= github.com/rhysd/actionlint/cmd/actionlint@v1.7.10

Expand Down Expand Up @@ -150,7 +149,6 @@ SVG_DEST_DIR := public/assets/img/svg

AIR_TMP_DIR := .air

GO_LICENSE_TMP_DIR := .go-licenses
GO_LICENSE_FILE := assets/go-licenses.json

TAGS ?=
Expand All @@ -159,7 +157,7 @@ TAGS_EVIDENCE := $(MAKE_EVIDENCE_DIR)/tags

TEST_TAGS ?= $(TAGS_SPLIT) sqlite sqlite_unlock_notify

TAR_EXCLUDES := .git data indexers queues log node_modules $(EXECUTABLE) $(DIST) $(MAKE_EVIDENCE_DIR) $(AIR_TMP_DIR) $(GO_LICENSE_TMP_DIR)
TAR_EXCLUDES := .git data indexers queues log node_modules $(EXECUTABLE) $(DIST) $(MAKE_EVIDENCE_DIR) $(AIR_TMP_DIR)

GO_DIRS := build cmd models modules routers services tests tools
WEB_DIRS := web_src/js web_src/css
Expand Down Expand Up @@ -473,11 +471,7 @@ tidy-check: tidy
go-licenses: $(GO_LICENSE_FILE) ## regenerate go licenses

$(GO_LICENSE_FILE): go.mod go.sum
@rm -rf $(GO_LICENSE_FILE)
$(GO) install $(GO_LICENSES_PACKAGE)
-GOOS=linux CGO_ENABLED=1 go-licenses save . --force --save_path=$(GO_LICENSE_TMP_DIR) 2>/dev/null
$(GO) run build/generate-go-licenses.go $(GO_LICENSE_TMP_DIR) $(GO_LICENSE_FILE)
@rm -rf $(GO_LICENSE_TMP_DIR)
GO=$(GO) $(GO) run build/generate-go-licenses.go $(GO_LICENSE_FILE)
Comment thread
silverwind marked this conversation as resolved.

generate-ini-sqlite:
sed -e 's|{{REPO_TEST_DIR}}|${REPO_TEST_DIR}|g' \
Expand Down Expand Up @@ -819,7 +813,6 @@ deps-tools: ## install tool dependencies
$(GO) install $(MISSPELL_PACKAGE) & \
$(GO) install $(SWAGGER_PACKAGE) & \
$(GO) install $(XGO_PACKAGE) & \
$(GO) install $(GO_LICENSES_PACKAGE) & \
$(GO) install $(GOVULNCHECK_PACKAGE) & \
$(GO) install $(ACTIONLINT_PACKAGE) & \
wait
Expand Down
Loading
Loading