Fix issues filter dropdown showing empty label scope section (#36535)#36544
Merged
wxiaoguang merged 3 commits intogo-gitea:release/v1.25from Feb 8, 2026
Merged
Fix issues filter dropdown showing empty label scope section (#36535)#36544wxiaoguang merged 3 commits intogo-gitea:release/v1.25from
wxiaoguang merged 3 commits intogo-gitea:release/v1.25from
Conversation
…a#36535) The issues filter dropdown always rendered the label scope divider and header, even when .ExclusiveLabelScopes was empty. This PR wraps the label scope section with a conditional so the divider/header and scope entries are only displayed when scopes exist. Before The dropdown showed a divider and “Label” header even when there were no exclusive label scopes available. <img width="521" height="569" alt="image" src="https://github.com/user-attachments/assets/9766df6b-c11b-46f3-aabc-9fa5f4ca767d" /> After The label scope section is hidden entirely when .ExclusiveLabelScopes is empty, keeping the dropdown clean and consistent. <img width="329" height="485" alt="image" src="https://github.com/user-attachments/assets/e9586e57-2be5-43ea-8a13-9b87c951be6f" /> Notes UI-only change, no behavior change to filtering logic.
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Feb 6, 2026
GiteaBot
added
lgtm/need 1
Member
|
Depends on #36542. |
lunny
approved these changes
Feb 6, 2026
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36535 by @tyroneyeh
The issues filter dropdown always rendered the label scope divider and header, even when .ExclusiveLabelScopes was empty.
This PR wraps the label scope section with a conditional so the divider/header and scope entries are only displayed when scopes exist.
Before
The dropdown showed a divider and “Label” header even when there were no exclusive label scopes available.
After
The label scope section is hidden entirely when .ExclusiveLabelScopes is empty, keeping the dropdown clean and consistent.
Notes
UI-only change, no behavior change to filtering logic.