Fix bug when do LFS GC by lunny · Pull Request #36500 · go-gitea/gitea

lunny · 2026-01-30T20:21:30Z

Removed unnecessary parameters from the LFS GC process and switched to an ORDER BY id ASC strategy with a last-ID cursor to avoid missing or duplicating meta object IDs.

Copilot

Pull request overview

Fixes the LFS GC hang reported in #36448 by making LFS meta-object iteration stable and monotonic (ID-based cursor), preventing repeated batches when records are updated during iteration.

Changes:

Simplified IterateLFSMetaObjectsForRepoOptions by removing unused/unsafe iteration modes.
Reworked IterateLFSMetaObjectsForRepo to page via ORDER BY id ASC + id > lastID cursor (no offset paging).
Added regression tests covering GC autofix and iteration behavior when rows are updated mid-iteration.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
services/repository/lfs.go	Stops passing the removed iteration parameters; relies on the new ID-cursor iteration behavior.
models/git/lfs.go	Implements ID-based cursor pagination for LFSMetaObject iteration and removes the old ordering/offset options.
services/repository/lfs_test.go	Adds a repo-scoped GC autofix test (and imports `modules/test` for mocking).
models/git/lfs_test.go	Adds a regression test ensuring iteration doesn’t skip/hang when meta rows are updated during the loop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

services/repository/lfs_test.go

models/git/lfs_test.go

services/repository/lfs_test.go

models/git/lfs_test.go

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

services/repository/lfs_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

…fix_lfs_gc

Fix go-gitea#36448 Removed unnecessary parameters from the LFS GC process and switched to an ORDER BY id ASC strategy with a last-ID cursor to avoid missing or duplicating meta object IDs. --------- Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@lunny

Backport #36500 by @lunny Fix #36448 Removed unnecessary parameters from the LFS GC process and switched to an ORDER BY id ASC strategy with a last-ID cursor to avoid missing or duplicating meta object IDs. Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* origin/main: (2555 commits) automate updating nix flakes (go-gitea#35641) Update AGENTS.md instructions (go-gitea#36627) use user id in noreply emails (go-gitea#36550) feat(db): Improve BuildCaseInsensitiveLike with lowercase (go-gitea#36598) [skip ci] Updated translations via Crowdin BUG: Fix workflow run jobs API returning null steps (go-gitea#36603) Refactor highlight and diff (go-gitea#36599) Fix bug when do LFS GC (go-gitea#36500) feature to be able to filter project boards by milestones (go-gitea#36321) Update emoji data for Unicode 16 (go-gitea#36596) Adapt monaco error matching pattern to recent webpack config change (go-gitea#36533) Fix a bug user could change another user's primary email (go-gitea#36586) fix(repo-editor): disable Monaco `editContext` to avoid bugs with lost focus (go-gitea#36585) Fine tune diff highlighting (go-gitea#36592) Add code editor setting dropdowns (go-gitea#36534) Update to go 1.26.0 and golangci-lint 2.9.0 (go-gitea#36588) Improve diff highlighting (go-gitea#36583) Fix markup code block layout (go-gitea#36578) Remove striped tables in UI (go-gitea#36509) Fix vertical alignment of `.commit-sign-badge` children (go-gitea#36570) ... # Conflicts: # custom/conf/app.example.ini # docs/content/administration/config-cheat-sheet.en-us.md # docs/content/administration/config-cheat-sheet.zh-cn.md # modules/setting/security.go # routers/common/errpage.go # services/context/api.go # services/context/context.go

Fix go-gitea#36448 Removed unnecessary parameters from the LFS GC process and switched to an ORDER BY id ASC strategy with a last-ID cursor to avoid missing or duplicating meta object IDs. --------- Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lunny added type/bug backport/v1.25 This PR should be backported to Gitea 1.25 labels Jan 30, 2026

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 30, 2026

github-actions bot added the modifies/go Pull requests that update Go code label Jan 30, 2026

lunny added 3 commits January 30, 2026 13:02

Fix bug when do LFS GC

c8259c6

correct copyright year

2be938c

Fix test

6bf7e47

lunny force-pushed the lunny/fix_lfs_gc branch from 96a4bee to 6bf7e47 Compare January 30, 2026 21:02

lunny requested a review from Copilot January 31, 2026 00:00

Copilot started reviewing on behalf of lunny January 31, 2026 00:01 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

services/repository/lfs_test.go Outdated Show resolved Hide resolved

models/git/lfs_test.go Outdated Show resolved Hide resolved

Follow reviews

1bb4b9a

silverwind approved these changes Jan 31, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2026

wxiaoguang reviewed Jan 31, 2026

View reviewed changes

services/repository/lfs_test.go Outdated Show resolved Hide resolved

lunny added 3 commits January 31, 2026 10:37

improvement

e6ad8bf

remove unnecessary change

aaf9470

remove unnecessary change

f400574

wxiaoguang reviewed Feb 1, 2026

View reviewed changes

models/git/lfs_test.go Outdated Show resolved Hide resolved

lunny added 4 commits January 31, 2026 22:11

Fix bug

0d9d5f8

Merge branch 'main' into lunny/fix_lfs_gc

e722d8c

Merge branch 'main' into lunny/fix_lfs_gc

b2879d7

Merge branch 'main' into lunny/fix_lfs_gc

7792f81

silverwind requested a review from Copilot February 12, 2026 08:15

Copilot started reviewing on behalf of silverwind February 12, 2026 08:16 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

services/repository/lfs_test.go Show resolved Hide resolved

services/repository/lfs_test.go Outdated Show resolved Hide resolved

lunny and others added 3 commits February 12, 2026 09:43

Update services/repository/lfs_test.go

0fd0be6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

Fix test

d50a740

Merge branch 'main' into lunny/fix_lfs_gc

9dad02d

Merge branch 'lunny/fix_lfs_gc' of github.com:lunny/gitea into lunny/…

81ee160

…fix_lfs_gc

Zettat123 approved these changes Feb 12, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2026

Merge branch 'main' into lunny/fix_lfs_gc

e3e20f6

lunny merged commit d69b786 into go-gitea:main Feb 12, 2026
24 checks passed

GiteaBot added this to the 1.26.0 milestone Feb 12, 2026

lunny deleted the lunny/fix_lfs_gc branch February 12, 2026 23:27

GiteaBot mentioned this pull request Feb 13, 2026

Fix bug when do LFS GC (#36500) #36608

Merged

GiteaBot added the backport/done All backports for this PR have been created label Feb 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix bug when do LFS GC#36500

Fix bug when do LFS GC#36500
lunny merged 16 commits intogo-gitea:mainfrom
lunny:lunny/fix_lfs_gc

lunny commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

lunny commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants