Unify repo names in system notices by Copilot · Pull Request #36491 · go-gitea/gitea

Copilot · 2026-01-30T05:22:12Z

This PR fixes ensures that all system notices consistently include repository names in the format "Action description (owner/repo): error message".

Before:

Failed to update mirror repository 'owner/repo.git': error
Repository garbage collection failed for owner/repo.git. Stdout: ...
Delete repository files [owner/repo]: error
Migrate repository from failed: error

After:

Failed to update mirror repository (owner/repo): error
Repository garbage collection failed (owner/repo). Stdout: ...
Delete repository files (owner/repo): error
Migrate repository (owner/repo) from https://example.com failed: error

Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

services/migrations/migrate.go

Check if opts.OriginalURL is empty and adapt the notice message accordingly to avoid printing "from failed" when OriginalURL is not set (e.g., when using the API). Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com> Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

Copilot · 2026-01-30T06:10:24Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

code.onedev.io
- Triggering command: /tmp/go-build1922630367/b001/migrations.test /tmp/go-build1922630367/b001/migrations.test -test.testlogfile=/tmp/go-build1922630367/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o pkg/mod/github.c-errorsas pkg/mod/github.c-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet -p github.com/bleve-atomic mpile ux-amd64/pkg/too-buildtags (dns block)
- Triggering command: /tmp/go-build1789349796/b001/migrations.test /tmp/go-build1789349796/b001/migrations.test -test.testlogfile=/tmp/go-build1789349796/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)
gitlab.com
- Triggering command: /tmp/go-build1922630367/b001/migrations.test /tmp/go-build1922630367/b001/migrations.test -test.testlogfile=/tmp/go-build1922630367/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o pkg/mod/github.c-errorsas pkg/mod/github.c-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet -p github.com/bleve-atomic mpile ux-amd64/pkg/too-buildtags (dns block)
- Triggering command: /tmp/go-build1789349796/b001/migrations.test /tmp/go-build1789349796/b001/migrations.test -test.testlogfile=/tmp/go-build1789349796/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

services/migrations/migrate.go

This reverts commit 8344555.

services/migrations/migrate.go

Added TODO comment before the migration failure notice to document that opts.OriginalURL can be empty when migration is triggered via the API route, which doesn't set this field. The comment also suggests potential solutions. Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com> Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

Fixed the API migration endpoint to set opts.OriginalURL from form.CloneAddr, ensuring consistency with the web route and preventing empty URL in system notices. Removed the TODO comment since OriginalURL is now always populated. Since CloneAddr is a required field (binding:"Required"), OriginalURL will always be non-empty when the API validation passes. Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com> Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

silverwind · 2026-01-31T08:34:56Z

Tested the migration failure, looks good:

services/repository/create.go

silverwind · 2026-02-01T08:06:59Z

Updated PR description.

* origin/main: Fix incorrect vendored detections (go-gitea#36508) Bump alpine to 3.23, add platforms to `docker-dryrun` (go-gitea#36379) Unify repo names in system notices (go-gitea#36491) Allow scroll propagation outside code editor (go-gitea#36502) Refactor ActionsTaskID (go-gitea#36503) Update JS deps, remove `knip`, misc tweaks (go-gitea#36499) [skip ci] Updated translations via Crowdin Fix editorconfig not respected in PR Conversation view (go-gitea#36492) Add FOLDER_ICON_THEME configuration option (go-gitea#36496) Don't create self-references in merged PRs (go-gitea#36490) Use reserved .test TLD for unit tests (go-gitea#36498) Fix bug when list pull request commits (go-gitea#36485) Update some go dependencies (go-gitea#36489) chore: add comments for "api/healthz", clean up test env (go-gitea#36481)

* giteaofficial/main: (26 commits) [skip ci] Updated translations via Crowdin Remove and forbid `@ts-expect-error` (go-gitea#36513) Add resolve/unresolve review comment API endpoints (go-gitea#36441) Fix incorrect vendored detections (go-gitea#36508) Bump alpine to 3.23, add platforms to `docker-dryrun` (go-gitea#36379) Unify repo names in system notices (go-gitea#36491) Allow scroll propagation outside code editor (go-gitea#36502) Refactor ActionsTaskID (go-gitea#36503) Update JS deps, remove `knip`, misc tweaks (go-gitea#36499) [skip ci] Updated translations via Crowdin Fix editorconfig not respected in PR Conversation view (go-gitea#36492) Add FOLDER_ICON_THEME configuration option (go-gitea#36496) Don't create self-references in merged PRs (go-gitea#36490) Use reserved .test TLD for unit tests (go-gitea#36498) Fix bug when list pull request commits (go-gitea#36485) Update some go dependencies (go-gitea#36489) chore: add comments for "api/healthz", clean up test env (go-gitea#36481) [SECURITY] Toolchain Update to Go 1.25.6 (go-gitea#36480) [skip ci] Updated translations via Crowdin Render merged pull request title as such in dashboard feed (go-gitea#36479) ...

* origin/main: (1246 commits) fix(packages/container): data race when uploading container blobs concurrently (go-gitea#36524) [skip ci] Updated translations via Crowdin Remove and forbid `@ts-expect-error` (go-gitea#36513) Add resolve/unresolve review comment API endpoints (go-gitea#36441) Fix incorrect vendored detections (go-gitea#36508) Bump alpine to 3.23, add platforms to `docker-dryrun` (go-gitea#36379) Unify repo names in system notices (go-gitea#36491) Allow scroll propagation outside code editor (go-gitea#36502) Refactor ActionsTaskID (go-gitea#36503) Update JS deps, remove `knip`, misc tweaks (go-gitea#36499) [skip ci] Updated translations via Crowdin Fix editorconfig not respected in PR Conversation view (go-gitea#36492) Add FOLDER_ICON_THEME configuration option (go-gitea#36496) Don't create self-references in merged PRs (go-gitea#36490) Use reserved .test TLD for unit tests (go-gitea#36498) Fix bug when list pull request commits (go-gitea#36485) Update some go dependencies (go-gitea#36489) chore: add comments for "api/healthz", clean up test env (go-gitea#36481) [SECURITY] Toolchain Update to Go 1.25.6 (go-gitea#36480) [skip ci] Updated translations via Crowdin ... # Conflicts: # modules/templates/helper.go # options/locale/locale_en-US.ini # routers/web/repo/cherry_pick.go # routers/web/repo/editor.go # routers/web/repo/patch.go # templates/repo/editor/edit.tmpl # web_src/js/features/codeeditor.ts

Initial plan

9c6d64f

Copilot AI assigned Copilot and silverwind Jan 30, 2026

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 30, 2026

Copilot started work on behalf of silverwind January 30, 2026 05:28 View session

Copilot AI and others added 2 commits January 30, 2026 05:34

Add consistent repository names to all system notices

1fa0bda

Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

Address code review feedback: fix typo and improve message formatting

8c7a6a0

Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix issue with @go-gitea/gitea functionality~~ Standardize repository identification in system notices Jan 30, 2026

Copilot AI requested a review from silverwind January 30, 2026 05:46

Copilot finished work on behalf of silverwind January 30, 2026 05:46

github-actions bot added the modifies/go Pull requests that update Go code label Jan 30, 2026

silverwind reviewed Jan 30, 2026

View reviewed changes

services/migrations/migrate.go Show resolved Hide resolved

Copilot started work on behalf of silverwind January 30, 2026 06:01 View session

Copilot AI requested a review from silverwind January 30, 2026 06:10

Copilot finished work on behalf of silverwind January 30, 2026 06:10

wxiaoguang reviewed Jan 30, 2026

View reviewed changes

services/migrations/migrate.go Outdated Show resolved Hide resolved

Revert "Handle empty OriginalURL in migration failure notices"

ad0857e

This reverts commit 8344555.

silverwind reviewed Jan 30, 2026

View reviewed changes

services/migrations/migrate.go Show resolved Hide resolved

Copilot started work on behalf of silverwind January 30, 2026 08:47 View session

Copilot AI requested a review from silverwind January 30, 2026 08:53

Copilot finished work on behalf of silverwind January 30, 2026 08:53

Copilot started work on behalf of silverwind January 30, 2026 08:56 View session

Copilot finished work on behalf of silverwind January 30, 2026 09:04

github-actions bot added the modifies/api This PR adds API routes or modifies them label Jan 30, 2026

silverwind marked this pull request as ready for review January 31, 2026 08:34

silverwind approved these changes Jan 31, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2026

wxiaoguang reviewed Jan 31, 2026

View reviewed changes

services/repository/create.go Outdated Show resolved Hide resolved

pass repo to cleanupRepository and remove the loading

5c75e4a

silverwind changed the title ~~Standardize repository identification in system notices~~ Unify repo names in system notices Feb 1, 2026

silverwind added 5 commits February 1, 2026 09:09

fix spelling

c1f8412

fix all spellings

574f504

fix all spellings

7ef419c

fix all spellings

b5474d4

Merge branch 'main' into copilot/fix-issue-36211

e316774

wxiaoguang approved these changes Feb 1, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2026

wxiaoguang merged commit 072de7d into main Feb 1, 2026
28 checks passed

GiteaBot added this to the 1.26.0 milestone Feb 1, 2026

wxiaoguang deleted the copilot/fix-issue-36211 branch February 1, 2026 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unify repo names in system notices#36491

Unify repo names in system notices#36491
wxiaoguang merged 13 commits intomainfrom
copilot/fix-issue-36211

Copilot AI commented Jan 30, 2026 •

edited by silverwind

Loading

Uh oh!

Uh oh!

Copilot AI commented Jan 30, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

silverwind commented Jan 31, 2026

Uh oh!

Uh oh!

silverwind commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Jan 30, 2026 • edited by silverwind Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 30, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

silverwind commented Jan 31, 2026

Uh oh!

Uh oh!

silverwind commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jan 30, 2026 •

edited by silverwind

Loading