Skip to content

improve the compare page#36261

Merged
lunny merged 14 commits intogo-gitea:mainfrom
lunny:lunny/compare_improve
Jan 1, 2026
Merged

improve the compare page#36261
lunny merged 14 commits intogo-gitea:mainfrom
lunny:lunny/compare_improve

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Dec 29, 2025 •
edited
Loading

  • The compare page head title should be compare but not new pull request.
  • Use UnstableGuessRefByShortName instead of duplicated functions calls.
  • Direct-compare, tags, commits compare will not display New Pull Request button any more.

The new screenshot
image

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 29, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Dec 29, 2025
@go-gitea go-gitea deleted a comment from GiteaBot Dec 29, 2025
@lunny lunny force-pushed the lunny/compare_improve branch from bf1be5d to b05d5fc Compare December 29, 2025 02:39
wxiaoguang
wxiaoguang reviewed Dec 29, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2025
wxiaoguang
wxiaoguang reviewed Dec 30, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 30, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 30, 2025
View reviewed changes
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 30, 2025
lunny
lunny commented Dec 30, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 30, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2026
@lunny lunny merged commit 8373f7d into go-gitea:main Jan 1, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Jan 1, 2026
@lunny lunny deleted the lunny/compare_improve branch January 1, 2026 18:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 5, 2026
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d228c9a 
* giteaofficial/main:
  Move assign project when creating pull request to the same database transaction (go-gitea#36244)
  [skip ci] Updated translations via Crowdin
  Fix stats bug when syncing release (go-gitea#36285)
  Fix link/origin referrer and login redirect (go-gitea#36279)
  Always honor user's choice for "delete branch after merge" (go-gitea#36281)
  refactor(pprof): use explicit mux instead of DefaultServeMux (go-gitea#36276)
  improve the compare page (go-gitea#36261)
  mailer: pass request context to generateAdditionalHeadersForIssue (go-gitea#36274)
  feat(debian): use explicit, stronger defaults for newly generated repo signing keys (go-gitea#36236)
  Make "commit statuses" API accept slashes in "ref" (go-gitea#36264)

# Conflicts:
#	templates/base/footer_content.tmpl
#	templates/base/head_navbar.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

+1 more reviewer

@kerwin612 kerwin612 kerwin612 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @wxiaoguang @kerwin612 @Zettat123 @GiteaBot