Only turn links to current instance into hash links by silverwind · Pull Request #36237 · go-gitea/gitea

silverwind · 2025-12-23T18:24:28Z

Given the following markdown:

http://localhost:3500/silverwind/symlink-test/commit/a832c723cd116df44cce6271c4a89afa4d8ec670
http://localhost:3500/silverwind/remap-css/commit/19fe6cdf81f7ec50b8cac2d6c28fe7c42c1ffe14
https://github.com/silverwind/symlink-test/commit/a832c723cd116df44cce6271c4a89afa4d8ec670

Previously, all links would turn into hash link, even ones to external sites:

After this change, only links to the current instance, as identified by setting.AppURL are turned into hash links:

There is still one notable difference with GitHub where the second link should render like user/repo@<hash>, not <hash> as currently, I would like to fix that here as well.

wxiaoguang · 2025-12-23T22:41:53Z

modules/markup/html_commit.go

+		// only turn commit links to the current instance into hash link
+		if !strings.HasPrefix(strings.ToLower(ret.FullURL), strings.ToLower(setting.AppURL)) {


Multidomain support #8697

So what do we check instead of setting.AppURL? Is there a slice of "current app urls" somewhere?

There is no "current app urls" at the moment.

We could make server.ROOT_URL accept multiple URLs comma-separated, and then check against all of those.

Or is there a way to obtain the current URL/Origin in this function? Do we need to pass *http.Request or some context down all the way to this function?

I guess the only way to make it work based on request URL is to determine the current HTTP request origin (from HTTP headers Host, X-Forwarded-Host, X-Forwarded-Protocol and more) into markup.RenderContext, which will be quite complicated.

It'll certainly be easier to let the user configure multiple server.ROOT_URL.

I guess this can be used:

gitea/modules/httplib/url.go

Line 58 in eddf875

func GuessCurrentAppURL(ctx context.Context) string {

Now it's using IsCurrentGiteaSiteURL

Use the shared IsCurrentGiteaSiteURL helper instead of a manual string prefix check against setting.AppURL, enabling multidomain support and consistency with other markup processors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR updates markup post-processing so that commit-ish URLs are only rewritten into shortened “hash link” renderings when the URL points to the current Gitea instance (as identified via setting.AppURL), instead of rewriting external hosts too.

Changes:

Gate commit URL “hash link” rewriting behind httplib.IsCurrentGiteaSiteURL.
Update/add tests to ensure external commit URLs remain plain links while current-instance URLs still shorten.
Adjust markdown link rendering tests to use localhost URLs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
modules/markup/html_commit.go	Adds current-instance check before rewriting full-hash URLs into shortened commit links.
modules/markup/markdown/markdown_test.go	Updates link rendering expectations and inputs (now using localhost URLs).
modules/markup/html_test.go	Adds coverage for external vs current-instance commit URL rendering behavior.
modules/markup/html_internal_test.go	Updates expected output so external commit URLs remain unshortened.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

modules/markup/html_commit.go

modules/markup/html_test.go

modules/markup/markdown/markdown_test.go

…tests - Add IsCurrentGiteaSiteURL check to comparePatternProcessor so external compare URLs are no longer shortened into hash links, matching the existing behavior in fullHashPatternProcessor - Use MockVariableValue for setting.AppURL in tests to avoid leaking global state between tests - Update test expectations for external URLs that should no longer be shortened - Add test cases for external commit and compare URLs in markdown tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Only the commit and compare URLs need to use localhost:3000 to match AppURL for the IsCurrentGiteaSiteURL check. Other URLs (plain links, images, remote links) are unaffected by the hash-link shortening and don't need to change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use setting.AppURL prefix instead of hardcoded external URLs in tests that verify hash link shortening. This keeps expected output identical to main where possible, and removes redundant external URL test cases that are already covered elsewhere. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Given the following markdown: ``` http://localhost:3500/silverwind/symlink-test/commit/a832c723cd116df44cce6271c4a89afa4d8ec670 http://localhost:3500/silverwind/remap-css/commit/19fe6cdf81f7ec50b8cac2d6c28fe7c42c1ffe14 https://github.com/silverwind/symlink-test/commit/a832c723cd116df44cce6271c4a89afa4d8ec670 ``` Previously, all links would turn into hash link, even ones to external sites: <img width="849" height="89" alt="Screenshot 2025-12-23 at 19 19 13" src="https://github.com/user-attachments/assets/2ad35a18-4542-40a4-a838-7ab8ac8bc047" /> After this change, only links to the current instance, as identified by `setting.AppURL` are turned into hash links: <img width="850" height="87" alt="Screenshot 2025-12-23 at 19 18 56" src="https://github.com/user-attachments/assets/2c49a5b2-426c-4a82-a610-9b9da8dcfff9" /> There is still one notable [difference with GitHub](silverwind/symlink-test#20 (comment)) where the second link should render like `user/repo@<hash>`, not `<hash>` as currently, I would like to fix that here as well. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Only turn links to current instance into hash links

26904e8

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 23, 2025

silverwind marked this pull request as draft December 23, 2025 18:24

github-actions bot added the modifies/go Pull requests that update Go code label Dec 23, 2025

silverwind added 5 commits December 23, 2025 19:26

simplify

1793e51

fix TestRenderLinks

7e0a1e4

fix tests

c85aee1

remove slash

79c63e0

fix TestRender_AutoLink

b33a247

wxiaoguang reviewed Dec 23, 2025

View reviewed changes

silverwind and others added 2 commits February 12, 2026 19:25

Merge branch 'main' into hashlinks

2c950c4

silverwind marked this pull request as ready for review February 12, 2026 18:29

Copilot AI review requested due to automatic review settings February 12, 2026 18:29

Copilot started reviewing on behalf of silverwind February 12, 2026 18:31 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

modules/markup/html_commit.go Show resolved Hide resolved

modules/markup/html_commit.go Show resolved Hide resolved

modules/markup/html_test.go Outdated Show resolved Hide resolved

modules/markup/markdown/markdown_test.go Outdated Show resolved Hide resolved

silverwind and others added 3 commits February 12, 2026 19:52

lunny approved these changes Feb 12, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 12, 2026

wxiaoguang approved these changes Feb 16, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2026

silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 16, 2026

silverwind enabled auto-merge (squash) February 16, 2026 09:38

GiteaBot added 2 commits February 16, 2026 17:38

Merge branch 'main' into hashlinks

31a31d2

Merge branch 'main' into hashlinks

df419f1

silverwind merged commit 0e99932 into go-gitea:main Feb 16, 2026
24 checks passed

GiteaBot added this to the 1.26.0 milestone Feb 16, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 16, 2026

wxiaoguang deleted the hashlinks branch February 16, 2026 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only turn links to current instance into hash links#36237

Only turn links to current instance into hash links#36237
silverwind merged 13 commits intogo-gitea:mainfrom
silverwind:hashlinks

silverwind commented Dec 23, 2025 •

edited

Loading

Uh oh!

wxiaoguang Dec 23, 2025

Uh oh!

silverwind Dec 23, 2025

Uh oh!

wxiaoguang Dec 23, 2025

Uh oh!

silverwind Dec 23, 2025 •

edited

Loading

Uh oh!

silverwind Dec 23, 2025 •

edited

Loading

Uh oh!

silverwind Dec 23, 2025 •

edited

Loading

Uh oh!

silverwind Dec 24, 2025

Uh oh!

silverwind Feb 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		// only turn commit links to the current instance into hash link
		if !strings.HasPrefix(strings.ToLower(ret.FullURL), strings.ToLower(setting.AppURL)) {

Uh oh!

Conversation

silverwind commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

silverwind Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

silverwind commented Dec 23, 2025 •

edited

Loading

silverwind Dec 23, 2025 •

edited

Loading

silverwind Dec 23, 2025 •

edited

Loading

silverwind Dec 23, 2025 •

edited

Loading