Fix panic in blame view when a file has only a single commit#36230
Merged
wxiaoguang merged 1 commit intogo-gitea:mainfrom Dec 23, 2025
Merged
Fix panic in blame view when a file has only a single commit#36230wxiaoguang merged 1 commit intogo-gitea:mainfrom
wxiaoguang merged 1 commit intogo-gitea:mainfrom
Conversation
delvh
approved these changes
Dec 22, 2025
a1012112796
approved these changes
Dec 23, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 26, 2025
* giteaofficial/main: Fix panic when get editor config file (go-gitea#36241) Refactor compare router param parse (go-gitea#36105) [skip ci] Updated translations via Crowdin Use flatten translation keys (go-gitea#36225) Replace CSRF cookie with `CrossOriginProtection` (go-gitea#36183) Remove fomantic form module (go-gitea#36222) Fix panic in blame view when a file has only a single commit (go-gitea#36230) fix: spelling error in migrate-storage cmd utility (go-gitea#36226) # Conflicts: # templates/user/settings/security/twofa.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic in the repository blame view that occurs when rendering files
whose blame history consists of only a single commit.
In this case, the number of rendered blame rows can exceed the number of
highlighted lines returned by the syntax highlighter. The existing bounds check
incorrectly used
len(rows), which may be greater thanlen(unsafeLines),leading to an out-of-range access on
unsafeLinesand a runtime panic.The fix changes the bounds check to use
len(unsafeLines)instead, ensuring wenever index past the available highlighted lines.
This issue is reproducible with files that:
/blame/commit/<sha>/file).The change is minimal, safe, and does not affect normal blame rendering.
Example error:
Introduced with PR #36157