Skip to content

Use gitrepo's clone and push when possible #36093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 5 commits into from
Dec 10, 2025
Merged

Use gitrepo's clone and push when possible #36093

lunny merged 5 commits into from
Dec 10, 2025
+78 −76

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 5, 2025

1 Move IsRepositoryModelOrDirExist and CheckCreateRepository to service layer
2 Use gitrepo.Pushxxx instead of git.Push when possible
3 use gitrepo.Clonexxx instead of gitrepo.Clone when possible

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 5, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 5, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 9, 2025
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 10, 2025
@lunny lunny merged commit 24b81ac into go-gitea:main Dec 10, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 10, 2025
@lunny lunny deleted the lunny/refactor_clone_push branch December 10, 2025 17:41
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 10, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fabcc01 
* giteaofficial/main:
  Move some functions to gitrepo package to reduce RepoPath reference directly (go-gitea#36126)
  Make Golang correctly delete temp files during uploading (go-gitea#36128)
  [skip ci] Updated translations via Crowdin
  Support updating branch via API (go-gitea#35951)
  Use gitrepo's clone and push when possible (go-gitea#36093)
  Improve math rendering (go-gitea#36124)
  Add matching pair insertion to markdown textarea (go-gitea#36121)
  Changed a small typo in an error message and code comments. (go-gitea#36117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kerwin612 kerwin612 kerwin612 approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @kerwin612 @Zettat123 @GiteaBot @delvh