Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 29, 2025

Replace #36032
Fix #36030

This PR use net/smtp instead of gomail's smtp. Now github.com/wneessen/go-mail will be used only for generating email message body.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 29, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 1, 2025
@lunny lunny added the type/bug label Dec 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2025
@silverwind silverwind enabled auto-merge (squash) December 4, 2025 08:05
@silverwind silverwind merged commit ee6e371 into go-gitea:main Dec 4, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 4, 2025
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Dec 4, 2025
…36055)

Replace go-gitea#36032
Fix go-gitea#36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2025
silverwind pushed a commit that referenced this pull request Dec 4, 2025
…36083)

Backport #36055 by @lunny

Replace #36032
Fix #36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny deleted the lunny/use_std_smtp branch December 4, 2025 19:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 5, 2025
* giteaofficial/main:
  Add strikethrough button to markdown editor (go-gitea#36087)
  Move commit related functions to gitrepo package (go-gitea#35600)
  Fix the bug when ssh clone with redirect user or repository (go-gitea#36039)
  fix some file icon ui (go-gitea#36078)
  update golangci-lint to v2.7.0 (go-gitea#36079)
  Use Golang net/smtp instead of gomail's smtp to send email (go-gitea#36055)
  Fix edit user email bug in API (go-gitea#36068)
  [skip ci] Updated translations via Crowdin
@xnox xnox mentioned this pull request Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go mail to 0.7.2 adding 8BITMIME to MAIL FROM causing SMTP failtures.

6 participants