Skip to content

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 17, 2025

The "err" shouldn't be logged when:

  • it is handled by the following call (apiError)
  • it is handled by parent caller (auth.Verify)
  • it is not caused by us (resp.Write)

And improve some comments/messages by the way (Which I had planned to improve but was just too lazy to propose a "comment-only" PR)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 17, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jul 17, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 17, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 17, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 17, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 17, 2025
@wxiaoguang wxiaoguang merged commit de1114b into go-gitea:main Jul 17, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-log-err branch July 17, 2025 11:09
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 18, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Increase gap on latest commit (go-gitea#35104)
  Fix job status aggregation logic (go-gitea#35000)
  Fix some missed GitHeadRefName when renaming (go-gitea#35102)
  Fix error logs and improve some comments/messages (go-gitea#35105)
  Support Basic Authentication for archive downloads (go-gitea#35087)
  Run `uv run` with `--frozen` (go-gitea#35097)
  Improve package API log handling (go-gitea#35100)
  Rename pull request GetGitRefName to GetGitHeadRefName (go-gitea#35093)
  Fix review comment/dimiss comment x reference can be refereced back (go-gitea#35094)
  Fix submodule nil check (go-gitea#35096)
  Redirect to a presigned URL of HEAD for HEAD requests (go-gitea#35088)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants