Skip to content

Partially refresh notifications list #35010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 10, 2025
Merged

Partially refresh notifications list #35010

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8a63806
feat: partially load notifications list
anbraten Jul 9, 2025
65071d5
fix
Jul 9, 2025
a9c914f
fix
Jul 9, 2025
2e4add4
improve code
Jul 9, 2025
138cc99
refactor
wxiaoguang Jul 9, 2025
cb0c106
fix paging
wxiaoguang Jul 9, 2025
c3247a5
fix redirect
wxiaoguang Jul 9, 2025
45f1d57
fix SSE ...
wxiaoguang Jul 9, 2025
a646b32
fix htmx process, remove bfcache support
wxiaoguang Jul 9, 2025
11443d8
fix empty notice
wxiaoguang Jul 9, 2025
b0c1110
use ts strict type
wxiaoguang Jul 9, 2025
1712c11
Merge branch 'main' into htmx-notifications
wxiaoguang Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions routers/web/user/notification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ func NotificationStatusPost(ctx *context.Context) {
ctx.Redirect(url, http.StatusSeeOther)
}

// convert the action to the displayed list
if statusStr == "unread" {
ctx.SetFormString("q", "read")
} else {
ctx.SetFormString("q", "unread")
}
getNotifications(ctx)
if ctx.Written() {
return
Expand Down
66 changes: 25 additions & 41 deletions templates/user/notification/notification_div.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,50 +69,34 @@
</div>
<div class="notifications-buttons tw-items-center tw-justify-end tw-gap-1 tw-px-1">
{{if ne .Status 3}}
<form action="{{AppSubUrl}}/notifications/status" method="post">
{{$.CsrfTokenHtml}}
<input type="hidden" name="notification_id" value="{{.ID}}">
<input type="hidden" name="status" value="pinned">
<button class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.pin"}}"
data-url="{{AppSubUrl}}/notifications/status"
data-status="pinned"
data-page="{{$.Page.Paginater.Current}}"
data-notification-id="{{.ID}}"
data-q="{{$.Keyword}}">
{{svg "octicon-pin"}}
</button>
</form>
<button type="button" class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.pin"}}"
hx-post="{{AppSubUrl}}/notifications/status"
hx-target="#notification_div"
hx-swap="outerHTML"
hx-vals='{"notification_id": "{{.ID}}", "status": "pinned", "page": "{{$.Page.Paginater.Current}}", "_csrf": "{{$.CsrfToken}}", "noredirect": "true" }'
{{if eq .Status 3}}disabled{{end}}
>
{{svg "octicon-pin"}}
</button>
{{end}}
{{if or (eq .Status 1) (eq .Status 3)}}
<form action="{{AppSubUrl}}/notifications/status" method="post">
{{$.CsrfTokenHtml}}
<input type="hidden" name="notification_id" value="{{.ID}}">
<input type="hidden" name="status" value="read">
<input type="hidden" name="page" value="{{$.Page.Paginater.Current}}">
<button class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.mark_as_read"}}"
data-url="{{AppSubUrl}}/notifications/status"
data-status="read"
data-page="{{$.Page.Paginater.Current}}"
data-notification-id="{{.ID}}"
data-q="{{$.Keyword}}">
{{svg "octicon-check"}}
</button>
</form>
<button type="button" class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.mark_as_read"}}"
hx-post="{{AppSubUrl}}/notifications/status"
hx-target="#notification_div"
hx-swap="outerHTML"
hx-vals='{"notification_id": "{{.ID}}", "status": "read", "page": "{{$.Page.Paginater.Current}}", "_csrf": "{{$.CsrfToken}}", "noredirect": "true"}'
>
{{svg "octicon-check"}}
</button>
{{else if eq .Status 2}}
<form action="{{AppSubUrl}}/notifications/status" method="post">
{{$.CsrfTokenHtml}}
<input type="hidden" name="notification_id" value="{{.ID}}">
<input type="hidden" name="status" value="unread">
<input type="hidden" name="page" value="{{$.Page.Paginater.Current}}">
<button class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.mark_as_unread"}}"
data-url="{{AppSubUrl}}/notifications/status"
data-status="unread"
data-page="{{$.Page.Paginater.Current}}"
data-notification-id="{{.ID}}"
data-q="{{$.Keyword}}">
{{svg "octicon-bell"}}
</button>
</form>
<button type="button" class="btn interact-bg tw-p-2" title="{{ctx.Locale.Tr "notification.mark_as_unread"}}"
hx-post="{{AppSubUrl}}/notifications/status"
hx-target="#notification_div"
hx-swap="outerHTML"
hx-vals='{"notification_id": "{{.ID}}", "status": "unread", "page": "{{$.Page.Paginater.Current}}", "_csrf": "{{$.CsrfToken}}", "noredirect": "true"}'
>
{{svg "octicon-bell"}}
</button>
{{end}}
</div>
</div>
Expand Down