Use unique temp dirs in unit tests

[ethantkoenig]

Using a fixed directory causes problems if you run tests in parallel.

Using a fixed directory may have also caused tests to be flaky (e.g. https://drone.gitea.io/go-gitea/gitea/3530/8).

[codecov-io]

Codecov Report

Merging #3494 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
- Coverage   35.74%   35.72%   -0.02%     
==========================================
  Files         284      284              
  Lines       40778    40792      +14     
==========================================
- Hits        14576    14574       -2     
- Misses      24041    24054      +13     
- Partials     2161     2164       +3

Impacted Files	Coverage Δ
models/unit_tests.go	69.02% <14.28%> (-9.77%)	⬇️
models/repo_list.go	65.62% <0%> (-1.57%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5c1ba...9ba38f8. Read the comment docs.

[jonasfranz]

Code looks good to me. But I haven't tested it yet.

[lafriks]

Does integration tests also reuse these directories?

[ethantkoenig]

@lafriks No

[lafriks]

But we don't run tests in parallel I think

[ethantkoenig]

@lafriks I know, but

1. There's no reason not to use unique dirs, and
2. I don't know how else to explain the spurious test failures we've been seeing

[lafriks]

@ethantkoenig problem with this is that these directories will be left undeleted I think

[ethantkoenig]

@lafriks Good point, fixed

[lafriks]

@ethantkoenig as for 2nd point - To me it looks like something keeps running in background that uses repos and that's why there is problem that they can't be deleted for next test... I spend 5 hours on weekend trying to pinpoint where but with no success :(

[lafriks]

why not just use assert.NoError(t, err)?

[ethantkoenig]

There is no t variable

[lafriks]

yes, sorry, overlooked :)

[lafriks]

Please use removeAllWithRetry func

[ethantkoenig]

Done

[bkcsoft]

These should be defered. Not done at the end