Rework delete org and rename org UI #34762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/enhancement
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
hiifong
approved these changes
Jun 19, 2025
GiteaBot
added
lgtm/need 1
yp05327
approved these changes
Jun 20, 2025
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Jun 20, 2025
wxiaoguang
reviewed
Jun 20, 2025
wxiaoguang
reviewed
Jun 20, 2025
This reverts commit f2b5744.
wxiaoguang
reviewed
Jun 21, 2025
wxiaoguang
reviewed
Jun 21, 2025
wxiaoguang
reviewed
Jun 21, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 23, 2025
* giteaofficial/main: (22 commits) [skip ci] Updated translations via Crowdin Fix required contexts and commit status matching bug (go-gitea#34815) Add "Cancel workflow run" button to Actions list page (go-gitea#34817) Use `shallowRef` instead of `ref` in `.vue` files where possible (go-gitea#34813) Edit file workflow for creating a fork and proposing changes (go-gitea#34240) Refactor packages (go-gitea#34777) Refactor wiki (go-gitea#34805) [skip ci] Updated translations via Crowdin Upgrade htmx to 2.0.5 (go-gitea#34809) Forks repository list page follow other repositories page (go-gitea#34784) Add post-installation redirect based on admin account status (go-gitea#34493) Rework delete org and rename org UI (go-gitea#34762) Refactor editor (go-gitea#34780) Improve img lazy loading (go-gitea#34804) [skip ci] Updated translations via Crowdin Fix Feishu webhook signature verification (go-gitea#34788) Upgrade chi to v5.2.2 (go-gitea#34798) Fix the issue of abnormal interface when there is no issue-item on the project page (go-gitea#34791) Fix container range bug (go-gitea#34795) Fix OCI manifest parser (go-gitea#34797) ...
lunny
added a commit
that referenced
this pull request
Jun 26, 2025
Extract `UpdateRepository` Follow up #34762 --------- Co-authored-by: wxiaoguang <[email protected]>
|
Need to fix a regression due to modal+form abuse -> Fix modal + form abuse #34921 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem of the original implementation
Renaming organization will mix with organization's information change make the operation difficult to keep consistent.
This PR created a danger zone like what's repository setting. It also moved organization's
renameanddeleteoperations to this zone. The original updating repository will not change the name any more.This is also a step to extract the
updaterepositoryfunction completely.Before:
After: