Skip to content

Validate hex colors when creating/editing labels #34623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 7, 2025
Merged

Validate hex colors when creating/editing labels #34623

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1830e25
Validate hex colors when creating/editing labels
kemzeb Jun 6, 2025
3d39baf
Fix new label validation
lunny Jun 6, 2025
10bd974
Update backend changes + add web route tests
kemzeb Jun 6, 2025
6c3aa9b
Make regex more strict
kemzeb Jun 6, 2025
e76508a
Simplify org labels route changes
kemzeb Jun 6, 2025
fda7476
Update error messages for org labels + add missing assertion in test
kemzeb Jun 6, 2025
5ab2729
PR backend linter feedback
kemzeb Jun 6, 2025
76eaa99
fix
wxiaoguang Jun 7, 2025
e43f282
fix
wxiaoguang Jun 7, 2025
30b1da1
fix lint
wxiaoguang Jun 7, 2025
fb21747
Merge branch 'main' into fix/frontend-labels
wxiaoguang Jun 7, 2025
3fcbf06
add comment
wxiaoguang Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/issue/labels/label_edit_modal.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<div class="field">
<label for="color">{{ctx.Locale.Tr "repo.issues.label_color"}}</label>
<div class="column js-color-picker-input">
<input name="color" value="#70c24a" placeholder="#c320f6" required maxlength="7">
<input name="color" value="#70c24a" placeholder="#c320f6" required pattern="^#?[A-Fa-f0-9]+$" maxlength="7">
{{template "repo/issue/label_precolors"}}
</div>
</div>
Expand Down