Skip to content

Fix ACME panic #33178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

Fix ACME panic #33178

merged 3 commits into from
Jan 9, 2025

Conversation

@wxiaoguang
Copy link
Contributor

Fix #33177, Manually tested:

1.7364311850484018e+09	info	maintenance	started background certificate maintenance	{"cache": "0x1400ca64180"}
1.736431185054049e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.736431185058073e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.736431185058133e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Jan 9, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 9, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 9, 2025
@lunny lunny enabled auto-merge (squash) January 9, 2025 23:28
@lunny lunny merged commit 5b31077 into go-gitea:main Jan 9, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 9, 2025
@wxiaoguang @GiteaBot
Fix ACME panic (go-gitea#33178)
626cb12 
Fix go-gitea#33177, Manually tested:

````
1.7364311850484018e+09	info	maintenance	started background certificate maintenance	{"cache": "0x1400ca64180"}
1.736431185054049e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.736431185058073e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.736431185058133e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}
````
@GiteaBot GiteaBot mentioned this pull request Jan 9, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 9, 2025
lunny pushed a commit that referenced this pull request Jan 10, 2025
@GiteaBot @wxiaoguang
Fix ACME panic (#33178) (#33186)
ed1828c 
Backport #33178 by @wxiaoguang

Fix #33177, Manually tested:

````
1.7364311850484018e+09	info	maintenance	started background certificate maintenance	{"cache": "0x1400ca64180"}
1.736431185054049e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.736431185058073e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.736431185058133e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}
````

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9e7866c 
* giteaofficial/main:
  Fix raw file API ref handling (go-gitea#33172)
  [skip ci] Updated translations via Crowdin
  Fix ACME panic (go-gitea#33178)
  Automerge supports deleting branch automatically after merging (go-gitea#32343)
  Fix branch dropdown not display ref name (go-gitea#33159)
  Add .run to gitignore (go-gitea#33175)
  Fix assignee list overlapping in Issue sidebar (go-gitea#33176)
  Fix pam auth test regression (go-gitea#33169)
  Move repo size to sidebar (go-gitea#33155)
  Fix fuzz test (go-gitea#33156)
  Refactor older tests to use testify (go-gitea#33140)
  [skip ci] Updated translations via Crowdin
  Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146)
  Fix form width (go-gitea#33151)
  Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126)
  Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136)
  Add missed transaction on setmerged (go-gitea#33079)
@wxiaoguang wxiaoguang deleted the fix-acme branch January 10, 2025 01:46
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

acme crash in 1.23 preventing start of gitea

4 participants

@wxiaoguang @lunny @lafriks @GiteaBot