Validate OAuth Redirect URIs#32643
Merged
lunny merged 12 commits intogo-gitea:mainfrom Nov 28, 2024
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Nov 26, 2024
lunny
reviewed
Nov 26, 2024
lunny
approved these changes
Nov 27, 2024
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/blocked
Contributor
|
Feel free to discard my change request if the concern is addressed, in case I am not at computer. |
wxiaoguang
reviewed
Nov 28, 2024
wxiaoguang
approved these changes
Nov 28, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2024
* giteaofficial/main: Refactor render system (orgmode) (go-gitea#32671) Improve diff file tree (go-gitea#32658) Don't create action when syncing mirror pull refs (go-gitea#32659) Allow users with write permission to run actions (go-gitea#32644) Validate OAuth Redirect URIs (go-gitea#32643)
Contributor
|
-> Support for Custom URI Schemes in OAuth2 Redirect URIs #37356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a TODO in the code to validate the RedirectURIs when adding or editing an OAuth application in user settings.
This also includes a refactor of the user settings tests to only create the DB once per top-level test to avoid reloading fixtures.