Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in mermaid observer #32599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

william-allspice
Copy link
Contributor

@william-allspice william-allspice commented Nov 21, 2024

This Pull Request addresses a race condition in the updateIframeHeight function where it is sometimes called when the iframe is not fully loaded or accessible resulting in an alarming error message for the user.

Screenshot 2024-11-21 at 9 44 59 AM

I have reproduced this here: https://gitea.com/small_world/MermaidTest/src/branch/main/

Please note: This error is reproducible but it happens intermittently.

To address this we:

  1. Add defensive programming within the updateIframeHeight function
  2. Delay instantiating the intersection observer until the iframe has loaded

…delaying instantiation of the intersection observer
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants