Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line-through for deleted branch on pull request view page #32500

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Add line-through for deleted branch on pull request view page #32500

merged 14 commits into from
Nov 21, 2024
+11 −4

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 14, 2024 •
edited
Loading

Base branch deleted

图片

branch deleted comment

图片

Head branch deleted
图片

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Nov 14, 2024
@lunny lunny added this to the 1.23.0 milestone Nov 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2024
kerwin612
kerwin612 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kerwin612 kerwin612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@lunny lunny enabled auto-merge (squash) November 21, 2024 08:07
@lunny lunny merged commit a175f98 into go-gitea:main Nov 21, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@lunny lunny deleted the lunny/add_line_through_deleted_branch branch November 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@kerwin612 kerwin612 kerwin612 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @kerwin612 @Zettat123 @GiteaBot