Remove expire from context cache #32001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
delvh
approved these changes
Sep 7, 2024
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Sep 7, 2024
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
|
Wait for @wolfogre 's review. |
lunny
removed
the
reviewed/wait-merge
|
Please hold on. Why was the expiration time design introduced, to solve what problem, and why is it safe to remove it now that it is no longer a concern? This PR does not explain these questions. I will check it and review it later. |
wolfogre
added
the
lgtm/blocked
wolfogre
requested changes
Sep 8, 2024
There was a problem hiding this comment.
It doesn't LGTM. Please read the discussion in the comments of #23218. The expiration is used to avoid the context cache being used for long-term work. It is not really related to the lifecycle of the context itself.
My original idea was 5 minutes, not 10 seconds. So I suggest changing the duration from 10s to 5 minutes to reduce false reports instead of removing it entirely.
GiteaBot
removed
the
lgtm/done
lunny
pushed a commit
that referenced
this pull request
Sep 9, 2024
Replace #32001. To prevent the context cache from being misused for long-term work (which would result in using invalid cache without awareness), the context cache is designed to exist for a maximum of 10 seconds. This leads to many false reports, especially in the case of slow SQL. This PR increases it to 5 minutes to reduce false reports. 5 minutes is not a very safe value, as a lot of changes may have occurred within that time frame. However, as far as I know, there has not been a case of misuse of context cache discovered so far, so I think 5 minutes should be OK. Please note that after this PR, if warning logs are found again, it should get attention, at that time it can be almost 100% certain that it is a misuse.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 10, 2024
Replace go-gitea#32001. To prevent the context cache from being misused for long-term work (which would result in using invalid cache without awareness), the context cache is designed to exist for a maximum of 10 seconds. This leads to many false reports, especially in the case of slow SQL. This PR increases it to 5 minutes to reduce false reports. 5 minutes is not a very safe value, as a lot of changes may have occurred within that time frame. However, as far as I know, there has not been a case of misuse of context cache discovered so far, so I think 5 minutes should be OK. Please note that after this PR, if warning logs are found again, it should get attention, at that time it can be almost 100% certain that it is a misuse.
wolfogre
added a commit
that referenced
this pull request
Sep 11, 2024
) Backport #32011 by @wolfogre Replace #32001. To prevent the context cache from being misused for long-term work (which would result in using invalid cache without awareness), the context cache is designed to exist for a maximum of 10 seconds. This leads to many false reports, especially in the case of slow SQL. This PR increases it to 5 minutes to reduce false reports. 5 minutes is not a very safe value, as a lot of changes may have occurred within that time frame. However, as far as I know, there has not been a case of misuse of context cache discovered so far, so I think 5 minutes should be OK. Please note that after this PR, if warning logs are found again, it should get attention, at that time it can be almost 100% certain that it is a misuse. Co-authored-by: Jason Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a request took more than 10s, the warning
[W] cache context is expired, may be misused for long-life tasks: &{map[] {{0 0} 0 0 {{} 0} {{} 0}} {13956354484237509102 85424598204433 0x6a66660} false}, ref #31757 (comment) .The expiration has been introduced in #23330 and I approved. But now I'm suspecting if it's necessary. Since every request has it's own expiration time, the context cache should have the same lifecycle as the request.
So this PR just removed the expire checking, the context cache will still be available even if a SQL took over 10 seconds.