Fix sort order for organization home and user profile page #31921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Aug 26, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Aug 26, 2024
Co-authored-by: wxiaoguang <[email protected]>
6543
reviewed
Sep 1, 2024
6543
approved these changes
Sep 1, 2024
GiteaBot
added
lgtm/done
6543
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Sep 2, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 5, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Remove html tags from create tag and branch translation (go-gitea#31973) Replace v-html with v-text in search inputbox (go-gitea#31966) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Improve get feed with pagination (go-gitea#31821) Remove urls from translations (go-gitea#31950) Prevent update pull refs manually and will not affect other refs update (go-gitea#31931) [skip ci] Updated translations via Crowdin nix wording nit in todo code comment Fix 500 error when `state` params is set when editing issue/PR by API (go-gitea#31880) Fix sort order for organization home and user profile page (go-gitea#31921) Improve textarea paste (go-gitea#31948) Fix index too many file names bug (go-gitea#31903) [skip ci] Updated translations via Crowdin Move web globals to `web_src/js/globals.d.ts` (go-gitea#31943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31916
In #30876,
sortOrderhas been changed into a map, but it is only implemented in explore.But it seems that size sort order has no effect from long long ago,not directly caused by the PR above.I think it is still caused by #29231.
In #29231, it merged the sort orders from
templates/explore/repo_search.tmplandtemplates/admin/repo/search.tmpl.In
templates/admin/repo/search.tmpl, it contains size sort orders, but not intemplates/explore/repo_search.tmpl, which is used in non-admin pages.So
order by sizeis added from #29231, but the handler was not added.So maybe we should manually backport this fix to 1.22.Backport: #31922