Refactor the usage of batch catfile (#31754) #31889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a repository, it will call `ensureValidRepository` and also `CatFileBatch`. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository. This PR removed all of these from `OpenRepository` but only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked.
GiteaBot
added
modifies/go
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
approved these changes
Aug 20, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Aug 20, 2024
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #31754 by @lunny
When opening a repository, it will call
ensureValidRepositoryand alsoCatFileBatch. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository.This PR removed all of these from
OpenRepositorybut only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked.