Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): owner ID should be zero when created repo secret (#31715) #31811

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix(api): owner ID should be zero when created repo secret (#31715) #31811

merged 1 commit into from
Aug 9, 2024

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Aug 9, 2024

  • Change condition to include RepoID equal to 0 for organization secrets

Backport #31715 by @appleboy

@appleboy @GiteaBot
fix(api): owner ID should be zero when created repo secret (go-gitea#…
0efd5f2 
…31715)

- Change condition to include `RepoID` equal to 0 for organization
secrets

---------

Signed-off-by: Bo-Yi Wu <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added this to the 1.22.2 milestone Aug 9, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Aug 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 9, 2024
@lunny lunny merged commit e563297 into go-gitea:release/v1.22 Aug 9, 2024
26 checks passed
@appleboy appleboy deleted the patch branch August 10, 2024 08:17
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.2
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @lunny @wolfogre @GiteaBot