Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): owner ID should be zero when created repo secret #31715

Merged
merged 5 commits into from
Jul 29, 2024

Commits on Jul 28, 2024

  1. fix(api): owner ID should be zero when created repo secret

    - Change `owner.ID` to `0` in the `CreateOrUpdateSecret` function call
    
    Signed-off-by: Bo-Yi Wu <[email protected]>
    appleboy committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    fccdd24 View commit details
    Browse the repository at this point in the history
  2. refactor: refactor codebase for improved efficiency and clarity

    - Remove unused variable `owner` from `CreateOrUpdateSecret` function
    
    Signed-off-by: Bo-Yi Wu <[email protected]>
    appleboy committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d100d0d View commit details
    Browse the repository at this point in the history
  3. refactor: refactor secret deletion functions and improve tests

    - Remove unused `owner` variable in `DeleteSecret` function
    - Change `DeleteSecretByName` function call to use `0` instead of `owner.ID`
    
    Signed-off-by: Bo-Yi Wu <[email protected]>
    appleboy committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e323b6f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    4b48dba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    deaa66a View commit details
    Browse the repository at this point in the history